How can I write an if statement using a variable in a foreach loop using Powershell?

Question

I'm running the foreach loop below in my code right now, and it works great. However, I'd prefer to have it send one single email at the end of the script if the condition is met, instead of an email for each problem found. How can I do this?

foreach ($server in $servers) {
  $DT = Get-WmiObject -Class Win32_LocalTime -ComputerName $server
  $DateTime = (Get-Date -Day $DT.Day -Month $DT.Month -Year $DT.Year -Minute $DT.Minute -Hour $DT.Hour -Second $DT.Second)
  $SUTC = $DateTime.ToUniversalTime()
  $now = Get-Date
  $NUTC = $now.ToUniversalTime()
  $Difference = (New-TimeSpan -Start ($NUTC) -End  ($SUTC))
  Write-Host "Time at $server is $SUTC. Time difference of $Difference."
  if ($Difference -ge '00:03:00') {
    Send-MailMessage -Subject "Time Report -$(get-date -Format "MM-dd-yyy")" -Body "Time difference of more then 3 minutes detected." -SmtpServer "SMTPSERVER" -From "[email protected]" -To "[email protected]" -UseSsl
  } 
}

Kev · Accepted Answer · 2015-06-05 20:00:10Z

2

Declare an array before the foreach and add messages. Then call Send-MailMessage after your foreach. Example:

$errors =  @()   

foreach ($server in $servers) {
  $DT = Get-WmiObject -Class Win32_LocalTime -ComputerName $server
  $DateTime = (Get-Date -Day $DT.Day -Month $DT.Month -Year $DT.Year -Minute $DT.Minute -Hour $DT.Hour -Second $DT.Second)
  $SUTC = $DateTime.ToUniversalTime()
  $now = Get-Date
  $NUTC = $now.ToUniversalTime()
  $Difference = (New-TimeSpan -Start ($NUTC) -End  ($SUTC))
  Write-Host "Time at $server is $SUTC. Time difference of $Difference."
  if ($Difference -ge '00:03:00') {
    $errors += "Time difference of more then 3 minutes detected."
  } 
}

if($errors.Count -gt 0) {
    Send-MailMessage -Subject "Time Report -$(get-date -Format "MM-dd-yyy")" -Body ($errors -join "`n") -SmtpServer "SMTPSERVER" -From "[email protected]" -To "[email protected]" -UseSsl
}

edited Jun 5, 2015 at 20:00

Kev

120k53 gold badges308 silver badges396 bronze badges

answered Jun 5, 2015 at 15:24

wallybh

9621 gold badge11 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Ansgar Wiechers Over a year ago

Don't do this. Appending to an array in a loop is bound to perform poorly, because each time the array is re-created with size+1, and all existing elements are copied to the new instance. Instead just echo inside the loop and assign the loop output to a variable ($var = foreach ($server in $servers) { ... }).

wallybh Over a year ago

imo, append to an array will be a problem just for large data. But that don't deny your warning.

Ansgar Wiechers Over a year ago

True, for small amounts of data it usually isn't noticable, but you don't gain anything either.

Collectives™ on Stack Overflow

How can I write an if statement using a variable in a foreach loop using Powershell?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related