php codeigniter array undefined offset error

Question

i am using codeigniter, and i am declaring a variable array, i used the array and it worked fine, but php keep showing some error that does't affect the program. anyone know what's happen ?? this is my code :

view :

<?php
$banyak = 0;
$id = $results->id;
$barangNama = $results->nama;
$barangHarga = $results->harga;
$barangGambar = $results->gambar; //resulting string "1.jpg,2.jpg,3.jpg,4.jpg"

$s = 0;
//declare variable array
$newGambar = array();

for ($i = 0; $i < strlen($barangGambar); $i++) {
    if ($barangGambar[$i] == ',') {
        $s++;
    } else {
        /* here is line 90 */ $newGambar[$s] .= $barangGambar[$i];
    }
}

print_r($newGambar);
?>

<?php
$w = 0;
for ($i = 0; $i <= $s; $i++) {


    if ($w % 4 == 0) {
        $banyak++;
    }
    $w++;
    echo $banyak;
    ?>
    <div class="item <?php if ($i == 0) {
        echo "active";
    } ?>" data-thumb="<?php echo $banyak - 1; ?>">
        <img src="<?php echo base_url(); ?>assets/images/product_picture/<?php echo $newGambar[$i]; ?>">
    </div>

    <?php
}
?>

what i want to achieve is divided $barangGambar each coma, and input to $newGambar[0] = 1.jpg $newGambar[1] = 2.jpg and so on

but i have to loop to decide how many picture that provided

this is error msg :

    A PHP Error was encountered
    Severity: Notice
    Message: Undefined offset: 0
   Filename: webView/webProductZoomed.php
   Line Number: 90

Damien Pirsy · Accepted Answer · 2015-06-08 10:47:13Z

1

You're doing something strange here:

$newGambar[$s] .= $barangGambar[$i];

Maybe you meant: $newGambar[] = $barangGambar[$i]; ?

There's no need for a counter here, since every element added to the array will automatically receive an incremented index, so you'll still end up with $newGambar => array (0 => 'element1', 1 => 'element2') and so on

answered Jun 8, 2015 at 10:47

Damien Pirsy

25.5k8 gold badges72 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

raymond spark Over a year ago

what i mean is $newGambar[$s] = $newGambar[$s] . $barangGambar[$i]; it is same as $newGambar[$s] .= $barangGambar[$i];

raymond spark Over a year ago

lets just i asking this, if i want to take a string seperated by coma, and input every string into an array and insert to different index each, am i doing it right ?

Richard Parnaby-King · Accepted Answer · 2015-06-08 11:16:35Z

1

You wish to separate the string by comma and store the filenames in a new array? ie. turn "1.jpg,2.jpg,3.jpg,4.jpg" into array("1.jpg","2.jpg","3.jpg","4.jpg") ?

Replace:

for ($i = 0; $i < strlen($barangGambar); $i++) {
    if ($barangGambar[$i] == ',') {
        $s++;
    } else {
        /* here is line 90 */ $newGambar[$s] .= $barangGambar[$i];
    }
}

with:

$newGambar = explode(',',$barangGambar);

explode will split a string by the delimiter (in this case the comma ,) and store each part in the resulting array.

As for why undefined offset error:

During the first loop $newGamber[0] equals null (does not exist). As such attempting to concatenate onto it will return an undefined offset error. It is only a value has been placed into $newGamber[0] the error will stop.

edited Jun 8, 2015 at 11:16

answered Jun 8, 2015 at 11:10

Richard Parnaby-King

15k11 gold badges75 silver badges131 bronze badges

Comments

score 1 · Accepted Answer · 2015-06-08 11:28:44Z

1

remove . from this line and remove $s from array index

$newGambar[] = $barangGambar[$i];

edited Jun 8, 2015 at 11:28

answered Jun 8, 2015 at 10:46

user4904106

1 Comment

raymond spark Over a year ago

i am trying to insert a string there, please read the code again

Narendrasingh Sisodia · Accepted Answer · 2015-06-08 11:39:34Z

1

I'm not sure about your question but this'll work for you

$barangGambar = "1.jpg,2.jpg,3.jpg,4.jpg";

if(!empty($barangGambar)){
    $newGambar = explode(',',$barangGambar);
}

print_r($newGambar);

DEMO

answered Jun 8, 2015 at 11:39

Narendrasingh Sisodia

21.4k6 gold badges51 silver badges54 bronze badges

1 Comment

Narendrasingh Sisodia Over a year ago

And if there's another possibilities of string than post it within your question too..

Collectives™ on Stack Overflow

php codeigniter array undefined offset error

4 Answers 4

2 Comments

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related