Exit nested for loop in python

Question

I wanted to search through a csv file that will look up keywords from a list within the first two columns. I've managed to get it to work when a key word is found, but wanted to have a message if no keywords found. Unfortunately the message "not found" comes out four times. I just wanted this to come out once. Please can you help? What it's doing is going around each key word again.

import csv
keywords=["none","blank","off","screen","blank"]
f=open("CSVSolutions.csv")
for row in csv.reader(f):
    for keyword in keywords:
        if keyword == row[0] or keyword == row[1]:
            print(row[2])
            break
        else:
            print ("not found")
            break
f.close

call the close method f.close -> f.close()

Dušan Maďar
– Dušan Maďar

2015-06-08 22:17:11 +00:00
Commented Jun 8, 2015 at 22:17 — Dušan Maďar
– Dušan Maďar, Commented Jun 8, 2015 at 22:17

junnytony · Accepted Answer · 2015-06-08 22:18:41Z

3

You can use for.. else here like so:

for keyword in keywords:
    if keyword == row[0] or keyword == row[1]:
        break
else:
    print("not found")

answered Jun 8, 2015 at 22:18

junnytony

3,5551 gold badge25 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jonathan · Accepted Answer · 2015-06-08 22:23:33Z

3

Looks like you want to emit the message "Not found" only when the keywords were not found in the entire file?

try this:

import csv
keywords=["none","blank","off","screen","blank"]
f=open("CSVSolutions.csv")

for row in csv.reader(f):
    found = False;
    for keyword in keywords:
        if keyword == row[0] or keyword == row[1]:
            print(row[2])
            found = True
            break
    if not found:
        print ("not found")
        break

f.close()

The main point being that you should use another variable to track the state that you're looking for.

edited Jun 8, 2015 at 22:23

answered Jun 8, 2015 at 22:18

Jonathan

5,9242 gold badges26 silver badges24 bronze badges

Comments

Dleep · Accepted Answer · 2015-06-08 23:21:09Z

0

import csv
keywords=["none","blank","off","screen","blank"]

f=open("CSVSolutions.csv")
for row in csv.reader(f):
    if row[0] in keywords or row[1] in keywords:
        print(row[2])
    else:
        print ("not found")
f.close

I figured avoiding nested for entirely was easier. It may seem slower to iterate over the keywords list twice but it's basically equivalent to making two comparisons per item anyways.

edited Jun 8, 2015 at 23:21

answered Jun 8, 2015 at 22:20

Dleep

1,0675 silver badges12 bronze badges

3 Comments

Brent Washburne Over a year ago

Please add descriptions of your changes and/or code comments

Bayzid Ahmed Over a year ago

Thanks for all the help, the last code prints out four outputs, which I wanted to avoid. I will try the others

Bayzid Ahmed Over a year ago

Neither of the above worked unfortunately. The first one doesn't print anything when the keyword is found. The csv is very basic, you can imagine that the first two columns contain keywords, if they are matched that whatever is in column three is printed. Closess I get is Not found printing out 4 times. Can't see why that is. I've tried putting a break after the not found statement. Still no luck. But appreciate all the help

Collectives™ on Stack Overflow

Exit nested for loop in python

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related