TypeError - no implicit conversion of String into Integer in array Ruby on Rails

Question

I'm trying to make an area that outputs the following: [@month, @monthly_count] so that the complete output looks like this: [["January", 0], ["February", 0], ["March", 0], ["April", 2], ["May", 3], ["June", 19], ["July", 0], ["August", 0], ["September", 0], ["October", 0], ["November", 0], ["December", 0]]

I'm currently getting the error that TypeError - no implicit conversion of String into Integer: on the line @monthly_value_created[i] << @months[i] below.

Here is my code:

@months = ["January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December"]
@monthly_idea_value = [[0], [0], [0], [3], [35], [744], [0], [0], [0], [0], [0], [0]] 
#Array of arrays of integers isn't best, but unless it's causing the error I'm not worried about it right now.
#Bc the .flatten! method at the end fixes the output

      @monthly_value_created = Array.new(12){Array.new}
      i = 0
      12.times do |i|
        @monthly_value_created[i] << @months[i]
        @monthly_value_created[i] << @monthly_idea_value[i]
        @monthly_value_created.flatten!
        i += 1
      end

How can I avoid this error?

Santhosh · Accepted Answer · 2015-06-12 15:11:57Z

1

You can use Array#zip

@months.zip(@monthly_idea_value).map &:flatten

You don't need to map and flatten, if @monthly_idea_value is an Array of integers, instead of an Array of Arrays.

answered Jun 12, 2015 at 15:11

Santhosh

29.3k9 gold badges84 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Virge Assault Over a year ago

Would this replace the entire iteration? from i=0 to i +=1?

Santhosh Over a year ago

Yes it does. And there are many mistakes in your code, which 2called-chaos has explained in detail. Read that, and also learn how loops work in Ruby.

fylooi · Accepted Answer · 2015-06-12 15:10:08Z

0

Might probably be more efficient to do:

@months.map.each_with_index do |month, index|
  [month, @monthly_idea_value[index][0]]
end

answered Jun 12, 2015 at 15:10

fylooi

3,87016 silver badges24 bronze badges

Comments

2called-chaos · Accepted Answer · 2015-06-12 15:13:39Z

So you had two mistakes in your code.

First being incrementing i yourself while #times already passes the variable.

The second mistake you made is that you flattened the wrong thing (you only want to flatten the sub-array not the array structure you build.

@months = ["January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December"]
@monthly_idea_value = [[0], [0], [0], [3], [35], [744], [0], [0], [0], [0], [0], [0]]

@monthly_value_created = Array.new(12){Array.new}
12.times do |i|
  @monthly_value_created[i] << @months[i]
  @monthly_value_created[i] << @monthly_idea_value[i]
  @monthly_value_created[i].flatten!
end

=> [["January", 0], ["February", 0], ["March", 0], ["April", 3], ["May", 35], ["June", 744], ["July", 0], ["August", 0], ["September", 0], ["October", 0], ["November", 0], []]

Still fylooi's or Santhosh's approach is better and more ruby-ish :)

Collectives™ on Stack Overflow

TypeError - no implicit conversion of String into Integer in array Ruby on Rails

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related