Php if else with html

Question

Any help with figuring out why I get 'else' (T_ELSE) in your code on line in the code below?

 <?php if ( is_category( '3' ) )  ?>
        <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image1.png"></a></td>

  <?php if ( is_category( '1096' ) )  ?>
        <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image2.png"></a></td>

  <?php if ( is_category( '1437' ) )  ?>
        <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image3.png"></a></td>

  <?php if ( is_category( '1150' ) )  ?>
        <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image4.png"></a></td>

  <?php if ( is_category( '1138' ) )  ?>
        <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image.png"></a></td>

  <?php if ( is_category( '3' ) )  ?>
        <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image5.png"></a></td>

  <?php else : ?>
        <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image6.png"></a></td>
    <?php endif; ?>

you need to use : after the closing ) with this if usage. — b14r
– b14r, Commented Jun 16, 2015 at 19:26
I don't like this "if" usage, there are so many "<?php . . . ?>. Why not a "switch" with an "echo" for each "case"? — Jose Manuel Abarca Rodríguez
– Jose Manuel Abarca Rodríguez, Commented Jun 16, 2015 at 19:33
Actually your code seems too bit really redundant, you should shrink it a lot, @user3512391 — b14r
– b14r, Commented Jun 16, 2015 at 19:35
@JoseManuelAbarcaRodríguez Yeah that sounds good. But wouldn't it cause issues when echoing a relative url? As in the echo is a wordpress function. Wouldn't I have to hard code the img src url to make the echo work? — user3512391
– user3512391, Commented Jun 16, 2015 at 19:42
@user3512391, the idea is to remove so many "<?php . . . ?>". The rest of your code remains almost the same. But, if this style works for you, stick to it! — Jose Manuel Abarca Rodríguez
– Jose Manuel Abarca Rodríguez, Commented Jun 16, 2015 at 19:44

OllyBarca · Accepted Answer · 2015-06-16 19:24:45Z

Format your IF statement like so:

      <?php if (is_category('3')) : ?>
            <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image.png"></a></td>

      <?php elseif (is_category('1096')) : ?>
            <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image.png"></a></td>

      <?php elseif (is_category('1437')) : ?>
            <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image.png"></a></td>

      <?php elseif (is_category('1150')) : ?>
            <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image.png"></a></td>

      <?php elseif (is_category('1138')) : ?>
            <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image.png"></a></td>

      <?php elseif (is_category('3')) : ?>
            <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image.png"></a></td>

      <?php else : ?>
            <td class="logo-alts"><a href="/"><img src="<?php bloginfo('template_directory'); ?>/_images/image.png"></a></td>
        <?php endif; ?>

Collectives™ on Stack Overflow

Php if else with html

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related