Replacing if-else statement with Exception Handling

Question

I currently have the function below which has an if-else statement within it. After reading this post I thought it may be better to use try-catch Exception Handling instead. However, I am not sure how to do this. Basically, if the currency inputted is not AUD I want to throw an Exception with the print statement below.

def update(self, currency):
    if self.currency == 'AUD':
        url = 'http://www.rba.gov.au/statistics/tables/csv/f17-yields.csv'

        response = urllib2.urlopen(url)
        text = response.read()

        csvfile = StringIO.StringIO(text)
        df = pd.read_csv(csvfile)
        print df

    else:
        print('This currency is not available in Database')

I think I am missing a part of what you're looking for. If you want to throw an exception when currency isn't 'AUD', just do so after checking for currency: if self.currency != 'AUD': raise Exception — a p
– a p, Commented Jun 18, 2015 at 20:19
@ap I was hoping to raise the Exception along with the print statement above. — Jojo
– Jojo, Commented Jun 18, 2015 at 20:22
raise ValueError("...") and then do the handling where you call update — tynn
– tynn, Commented Jun 18, 2015 at 20:24
@ap I didn't realize it would be appropriate to raise an Exception without having try-catch — Jojo
– Jojo, Commented Jun 18, 2015 at 20:57

Blckknght · Accepted Answer · 2015-06-18 21:08:38Z

2

You generally don't want to be raising and catching an exception at the same place. Instead, you want to raise the exception where the error is first noticed, and catch it wherever it makes sense to report the issue.

In the code you've shown, you just want to replace the print call with a raise statement, probably of a ValueError. Pass the text you're printing as an argument to the exception:

raise ValueError('This currency is not available in Database')

Since you haven't shown where update is called, I don't know for sure where it would be appropriate to catch the exception. One reason that exceptions are useful (rather than if/else tests) is that you can let the exception bubble out of several functions or structural blocks if there's no useful way to handle them at that level.

answered Jun 18, 2015 at 21:08

Blckknght

106k11 gold badges135 silver badges188 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:29:41Z

0

Using exception handling instead of an if-else statement will be much slower.

I've benchmarked a similar comparison for locating a list of keys in a dictionary here, and timings are attached. For me, it was 5 times slower.

edited May 23, 2017 at 12:29

CommunityBot

11 silver badge

answered Jun 18, 2015 at 21:03

StackG

2,8685 gold badges31 silver badges46 bronze badges

Comments

Alex Huszagh · Accepted Answer · 2015-06-18 21:04:08Z

-1

If you want to force exception handling, you can use assert:

def update(self, currency):
    try:
        assert self.currency == 'AUD'
        url = 'http://www.rba.gov.au/statistics/tables/csv/f17-yields.csv'

        response = urllib2.urlopen(url)
        text = response.read()

        csvfile = StringIO.StringIO(text)
        df = pd.read_csv(csvfile)
        print df

    except AssertionError:
        print('This currency is not available in Database')

Not necessarily ideal in this case (this is a LBYL scenario, in my opinion), since the equality test should be faster, more readable, and scale better to more currencies, assuming you start off with a wide variety of different currencies.

answered Jun 18, 2015 at 21:04

Alex Huszagh

14.8k3 gold badges42 silver badges70 bronze badges

Collectives™ on Stack Overflow

Replacing if-else statement with Exception Handling

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related