recursive function inside for loop

Question

I m trying to create html in the controller instead of js. There is an array with unknown depth of arrays.

$tree = $repo->childrenHierarchy();

and a function who reads the array and returns a string of html with values from array elements.

 public function recursive($tree) {
        $html = "";
        foreach ($tree as $t) {
            $html = $html . '<li> <span><i class="fa fa-lg fa-minus-circle"></i>' . $t['title'] . '</span>';
            if ($t['__children'] != null) {
                $html = $html . '<ul>';
                $this->recursive($t['__children']);
                $html = $html . '</ul>';
            } else {
                $html = $html . '</li>';
            }
            return $html;
        }

My problem is that i cant hold the total string because everytime the function calls itself the var html is initialised, need to hold the string something like global but cant figure how.

try it but it is initialse $html evrytime

Giorgos Nikolaidhs
– Giorgos Nikolaidhs

2015-06-19 22:48:46 +00:00
Commented Jun 19, 2015 at 22:48 — Giorgos Nikolaidhs
– Giorgos Nikolaidhs, Commented Jun 19, 2015 at 22:48

Don't Panic · Accepted Answer · 2015-06-19 22:52:01Z

2

After looking at this a little more, I don't think it really looks like a problem that the $html is initialized in the recursive calls. It seems to me that it actually should start as empty for the children. But it doesn't look like you're appending the children to the $html string you already have going. I think you need

$this->recursive($t['__children']);

to be instead

$html .= $this->recursive($t['__children']);

answered Jun 19, 2015 at 22:52

Don't Panic

41.9k11 gold badges70 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

john Smith · Accepted Answer · 2015-06-19 22:48:14Z

0

there shouldnt be anything wrong with just storing that value in class property while action ?

public $html = "";

 public function recursive($tree) {
        foreach ($tree as $t) {
            $this->html = $this->html . '<li> <span><i class="fa fa-lg fa-minus-circle"></i>' . $t['title'] . '</span>';
            if ($t['__children'] != null) {
                $this->html = $this->html . '<ul>';
                $this->recursive($t['__children']);
                $this->html = $this->html . '</ul>';
            } else {
                $this->html = $this->html . '</li>';
            }
            return $this->html;
        }

answered Jun 19, 2015 at 22:48

john Smith

18k12 gold badges80 silver badges124 bronze badges

Collectives™ on Stack Overflow

recursive function inside for loop

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related