How escape html in echo of javascript

Question

I can't escape my code JS in my echo :

echo "<script type='text/javascript'>
    // Initialiser l'objet.
    var tab_nb_match_par_user = ".json_encode($tab_nb_match_par_user).";
    var taille = 70;    
    console.log(tab_nb_match_par_user);
    for (var k in tab_nb_match_par_user){
        $('#img').append('<img src="stats_matching/' + k + '.gif" alt="' + k + '" title="' + k + '" width="' + taille + '" />');
        taille = taille-6;
    }
</scrip>";

And I have this follow error: Uncaught SyntaxError: missing ) after argument list

And you seem to have some wrong quotes there. If you want to use double quote ( " ) in your javascript you have to escape them like \" — Gunni
– Gunni, Commented Jun 24, 2015 at 14:25

tuxPM · Accepted Answer · 2015-06-24 14:29:16Z

3

Use HEREDOC instead of echo.

echo <<<ENDOFSCRIPT
<script type='text/javascript'>

                    // Initialiser l'objet.
                    var tab_nb_match_par_user = ".json_encode($tab_nb_match_par_user).";
                    var taille = 70;    
                    console.log(tab_nb_match_par_user);
                    for (var k in tab_nb_match_par_user){
                        $('#img').append('<img src="stats_matching/' + k + '.gif" alt="' + k + '" title="' + k + '" width="' + taille + '" />');
                        taille = taille-6;
                    }
            </script>

ENDOFSCRIPT;

more info at https://wiki.php.net/rfc/heredoc-with-double-quotes

answered Jun 24, 2015 at 14:29

tuxPM

313 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DevDonkey · Accepted Answer · 2015-06-24 14:25:52Z

2

Assuming that you only want to actually have php fill in the json part, why not just echo in the bit you need, rather than the whole structure. This is much better practice in templating.

<script type='text/javascript'>
    // Initialiser l'objet.
    var tab_nb_match_par_user = "<?php echo json_encode($tab_nb_match_par_user) ?>";
    var taille = 70;    
    console.log(tab_nb_match_par_user);
    for (var k in tab_nb_match_par_user){
        $('#img').append('<img src="stats_matching/' + k + '.gif" alt="' + k + '" title="' + k + '" width="' + taille + '" />');
        taille = taille-6;
    }
 </script>

you were also missing a 't' in your end script tag.

answered Jun 24, 2015 at 14:25

DevDonkey

4,8902 gold badges30 silver badges43 bronze badges

Comments

fracz · Accepted Answer · 2015-06-24 21:33:09Z

2

echo <<<END
    <script type="text/javascript">
        // Initialiser l'objet.
        var tab_nb_match_par_user = ".json_encode($tab_nb_match_par_user).";
        var taille = 70;    
        console.log(tab_nb_match_par_user);
        for (var k in tab_nb_match_par_user){
            $('#img').append('<img src="stats_matching/' + k + '.gif" alt="' + k + '" title="' + k + '" width="' + taille + '" />');
            taille = taille-6;
        }
    </script>
END;

edited Jun 24, 2015 at 21:33

$fracz's user avatar$

fracz

21.4k18 gold badges109 silver badges154 bronze badges

answered Jun 24, 2015 at 14:26

techmoe

7111 bronze badges

Comments

Danny Broadbent · Accepted Answer · 2015-06-24 14:24:39Z

1

You need to escape the code using a back slash:

echo "<script type='text/javascript'>

                        // Initialiser l'objet.
                        var tab_nb_match_par_user = ".json_encode($tab_nb_match_par_user).";
                        var taille = 70;    
                        console.log(tab_nb_match_par_user);
                        for (var k in tab_nb_match_par_user){
                            $('#img').append('<img src=\"stats_matching/' + k + '.gif\" alt=\"' + k + '\" title=\"' + k + '\" width=\"' + taille + '\" />');
                            taille = taille-6;
                        }
                </scrip>";

answered Jun 24, 2015 at 14:24

Danny Broadbent

1,2091 gold badge10 silver badges21 bronze badges

Collectives™ on Stack Overflow

How escape html in echo of javascript

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related