Call JavaScript function(with parameters) by onclick event

Question

I cant use PHP variables to use as parameters for my function.

The function is:

<script type="text/javascript">
function myFunction(id,name) {
    alert(id);
    alert(name);
}
</script>

And this is PHP part:

echo "<button onclick='myFunction($intvar,$strvar)' type='button'>ClickMe</button>";

the call works when I use numbers like this: myFunction(0,1) but I need to use variables to call myFunction.

Please Help, thanks.

change alert(ide); to alert(id);

Vivek Singh
– Vivek Singh

2015-06-25 06:19:31 +00:00
Commented Jun 25, 2015 at 6:19 — Vivek Singh
– Vivek Singh, Commented Jun 25, 2015 at 6:19

Ambal Mani · Accepted Answer · 2015-06-25 06:25:00Z

6

You try this function myFunction(ide,name) { change insted of id => ide echo "<button onclick='myFunction(".'"'.$intvar.'","'.$strvar.'"'.")' type='button'>ClickMe</button>";

edited Jun 25, 2015 at 6:25

answered Jun 25, 2015 at 6:21

Ambal Mani

3151 gold badge5 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dfsq · Accepted Answer · 2015-06-25 06:29:31Z

5

Good practice is to echo json encoded version of variables, this way you ensure that strings are properly quoted:

echo "<button onclick='myFunction(" . json_encode($intvar) . "," . json_encode($strvar, JSON_HEX_APOS) . ")' type='button'>ClickMe</button>";

edited Jun 25, 2015 at 6:29

answered Jun 25, 2015 at 6:23

dfsq

193k26 gold badges244 silver badges261 bronze badges

3 Comments

dfsq Over a year ago

It will if you provide a flag JSON_HEX_APOS.

Roberto Sepúlveda Bravo Over a year ago

I try with json_encode and works too, thanks too much.

user2864740 Over a year ago

But now if double quotes are used for the attribute.. sigh. The problem is there is not (nor has there been) a good way to supply values as JavaScript arguments in attributes. So much for being a[n HTML] 'template' language ..

Collectives™ on Stack Overflow

Call JavaScript function(with parameters) by onclick event

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related