java: check boolean in for loop

Question

If work.length is 4 , I have to check the AResult in for loop If 4 AResult all are true ,set result.setstatus("success"); or result.setstatus("fail");
What can I do ??

        for(int i = 0;i < work.length;i++){ 
            if(!work[i].contains("#")){                          
                CommandLineInterface CLI = new CommandLineInterface();
                String IP = null;
                boolean AResult;

                try {                       
                    AResult = CLI.Setting(work[i],"start"); //true or false                                     
                } catch (JSchException | InterruptedException e) {
                    e.printStackTrace();
                }       
            }        
        }
        //result.setstatus("success"); //all true
        //result.setstatus("fail");

You are setting the value, not checking it.what 's the problem with adding an if-statement to set the status? — Stultuske
– Stultuske, Commented Jun 27, 2015 at 7:43
if the first loop is fail,and the last loop is success.the result.setstatus() would be success. But actually, the first loop is fail. — user2492364
– user2492364, Commented Jun 27, 2015 at 7:46
as soon as a 'false' is encountered, you don't longer need to loop over the other elements, since you have your answer, so break out of the loop. — Stultuske
– Stultuske, Commented Jun 27, 2015 at 7:47

Elliott Frisch · Accepted Answer · 2015-06-27 08:11:30Z

1

Add a counter. Increment it when your condition is true. Check the value of the counter after your loop. Something like

int counter = 0;
for(int i = 0;i < work.length;i++){ 
    if(!work[i].contains("#")){                          
        CommandLineInterface CLI = new CommandLineInterface();
        String IP = null;
        boolean AResult;

        try {                       
            AResult = CLI.Setting(work[i],"start");
            if (AResult) {
                counter++;
            }                                     
        } catch (JSchException | InterruptedException e) {
            e.printStackTrace();
        }       
    }        
}
if (work.length == 4 && counter == 4) {
    result.setstatus("success");
} else {
    result.setstatus("fail");
}

You could optimize the above (and reduce the code size) with something like

int counter = 0;
if (work.length == 4) { // <-- check the length first
    for (int i = 0; i < work.length; i++) {
        if (!work[i].contains("#")) {
            CommandLineInterface CLI = new CommandLineInterface();
            try {
                if (CLI.Setting(work[i], "start")) {
                    counter++; // <-- increment the counter.
                } else {
                    break; // <-- break on any fale.
                }
            } catch (Exception e) {
                e.printStackTrace();
            }
        }
    }
}
result.setstatus(counter == 4 ? "success" : "fail"); // <-- setstatus

edited Jun 27, 2015 at 8:11

answered Jun 27, 2015 at 7:47

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Stultuske Over a year ago

Wouldn't breaking out the loop when a false occurs be more efficiënt ? especially if work has thousands of elements and the first element is already false.

Elliott Frisch Over a year ago

@Stultuske Only given a very strict interpretation of OP's stated requirements, specifically OP has stated what to do if the length is 4 and counter is 4 (or not). But nothing indicates those are the only requirements. Finally, an optimization of a break in the loop (and to check the work.length before begining the loop) might be in order; but it seems premature to me based on what OP asked.

Stultuske Over a year ago

In his question, he has: If 4 AResult all are true. so, as soon as one is false: the result is false.

Elliott Frisch Over a year ago

@Stultuske Actually, the result is fail... but I take your point.

KDP · Accepted Answer · 2015-06-27 07:53:22Z

0

try this, you really don't need to iterate the loop till end when a false condition is encountered in between

 //initially set success
 result.setstatus("success");
 for(int i = 0;i < work.length;i++){ 
if(!work[i].contains("#")){                          
    CommandLineInterface CLI = new CommandLineInterface();
    String IP = null;


    try {                       
       if(CLI.Setting(work[i],"start"))
         {
         result.setstatus("fail");
           //no need to iterate further
           break;
        }                                 
    } catch (JSchException | InterruptedException e) {
        e.printStackTrace();
    }       
}

}

answered Jun 27, 2015 at 7:53

KDP

1,4817 silver badges13 bronze badges

1 Comment

Elliott Frisch Over a year ago

And if work contains three elements (or five elements)?

Madhuri M · Accepted Answer · 2015-06-27 08:26:03Z

0

You can also try the following code

    boolean statusFlag = true; 
    for(int i = 0;i < work.length;i++){ 
        if(!work[i].contains("#")){                          
            CommandLineInterface CLI = new CommandLineInterface();
            String IP = null;
            boolean AResult;
            try {                       
                AResult = CLI.Setting(work[i],"start"); //true or false 
                if(!AResult){
                    statusFlag = false; 
                }
            } catch (JSchException | InterruptedException e) {
                e.printStackTrace();
            }       
        }        
    }
    if(statusFlag){
        result.setstatus("success"); 

    }else{
        result.setstatus("fail"); 
    }
}

answered Jun 27, 2015 at 8:26

Madhuri M

757 bronze badges

1 Comment

Madhuri M Over a year ago

You can put a break if you want to come out of the loop if you get false the first time if(!AResult){ statusFlag = false; break; }

Collectives™ on Stack Overflow

java: check boolean in for loop

3 Answers 3

4 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related