Getting subarray from one array

Question

There is an exercise that asks for the biggest sub-array inside one specific array, and the sub-array should not have repeated elements.

I do not have to worry about complexity and efficiency right now

The array is [8,2,2,3,4,1,6,5,1,7]

As far as i understand, the biggest subarray without repeated elements is: [2,3,4,1,6,5,7]

But they say that my function should output the [2,3,4,1,6,5]

Why?

This is my code:

int existe(int chk, int v[], int tam){
    int i;

    for(i=0; i<tam; i++){
        if(v[i]==chk){
            return 1;
        }
    }

    return 0;
}

int removeb(int v[], int n){
    int i, max, j;
    max = 0; 

    for(i=0; i<n; i++){
        if(v[i]>max){
            max = v[i];
        }
    }
    for(i=0; i<n; i++){
        if(v[i]==max){
            j=i;
            while(j<n){
                v[j]=v[j+1];
                j++;
            }
            return j-1;
        }
    }
    return n;
}


int maxuniqueseq(int v[], int N){
    int i, j, newsize;
    int tmp[N];

    //newsize = removeb(v, N);
    printf("%d\n", N);

    for(i=0; i<N; i++){
        tmp[i] = v[i];
    }
    for(i=0, j=0; i<N; i++){
        if(existe(tmp[i],v, i)){
            ;
        }else{
            v[j]=tmp[i];
            j++;
        }
    }

    newsize = removeb(v, j);


    return newsize;
}

Output with the above array:

[2,3,4,1,6,5,7]

With another example:

[8,2,2,3,4,12,6,5,1,7]

outputs: [8,2,3,4,6,5,1,7]

If you think [2,3,4,1,6,5,7] is the biggest subarray then what happened to the 1 between 5 and 7 which is there in the original array ? — P.P
– P.P, Commented Jun 28, 2015 at 19:11
You would be needing biggest contiguous subarray. Else for biggest subarray it would be [8,2,3,4,1,6,5,7]. In either case your answer is wrong. — Rakholiya Jenish
– Rakholiya Jenish, Commented Jun 28, 2015 at 19:12
as i understand it, if i have [1,2,3,4,5], the biggest subarray is [1,2,3,4] — skills
– skills, Commented Jun 28, 2015 at 19:13
what about 5, it should be [1,2,3,4,5]. You need biggest contiguous subarray, it can be array itself. — Rakholiya Jenish
– Rakholiya Jenish, Commented Jun 28, 2015 at 19:17

Community · Accepted Answer · 2020-06-20 09:12:55Z

2

I think the problem is with your interpretation of sub-array.

This is what a sub-array is

A subarray is commonly defined as a part or section of an array.

Hence the elements you are selecting need to be contiguous.

With an example,

suppose [10, 20, 50, 15, 10, 25, 45] is the array,

a sub-array for this would be [10, 20, 50]

where as [10, 50, 25] can not be called as a sub-array.

And the biggest sub-array without repeated elements would be [ 20, 50, 15, 10, 25, 45]

So change your code and give another try!

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Jun 28, 2015 at 19:16

Shri

8341 gold badge12 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

skills Over a year ago

What does contiguous mean? English is not my language. Can you give me an example of an array and a subarray and explain why is that a sub-array? Thank you so much .

Rakholiya Jenish Over a year ago

@skills contiguous, means all adjacent and continuous elements.

Vlad from Moscow Over a year ago

@skills It would be useful if you write in ypur profile where you are from.:)

skills Over a year ago

@RakholiyaJenish but they do not speak about contiguous in the exercise, the answer [2,3,4,1,6,5] has elements that are not adjacent and continuous, after 1, why 6?

Ediac Over a year ago

@skills in the original array, 6 is right next to 1

|

Collectives™ on Stack Overflow

Getting subarray from one array

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related