What's wrong with below code? Why I got an Uncaught SyntaxError: Unexpected token (
function Person(name){
sayHi: function(){
return "hi " + this.name;
}
}
var john = new Person("John");
alert(john.sayhi());
-
1The first '{' starts a function, not an object literal..user2864740– user28647402015-07-03 04:52:55 +00:00Commented Jul 3, 2015 at 4:52
-
3function Person(name){ return {sayHi: function(){ return "hi " + this.name; }} }Daniel Tate– Daniel Tate2015-07-03 04:53:04 +00:00Commented Jul 3, 2015 at 4:53
-
@user2864740 how to make it into an object?Alice Xu– Alice Xu2015-07-03 04:55:12 +00:00Commented Jul 3, 2015 at 4:55
-
1Besides what @DanielTate said, you are calling 'sayhi' but you defined it as 'sayHi'Hige– Hige2015-07-03 04:55:14 +00:00Commented Jul 3, 2015 at 4:55
Add a comment
|
6 Answers
The problem is that declaration of sayHi is invalid because you are not in the same context as an object literal, so you are having a syntax error.
var o = { sayHi: function() {}} ;
you could do it using "this" (Because you are using "new" already) :
function Person(name){
this.sayHi = function(){
return "hi " + name;
}
}
var john = new Person("John");
alert(john.sayHi());
another way is
function Person(name){
return {
sayHi : function() {
return "hi " + name;
}
}
}
var john = Person("John");
alert(john.sayHi());
Comments
You should use this to make the variables and functions public of a class. If you dont use this keyword with variables then they can only accessible inside the class.
Please check this code.
function Person(name){
this.sayHi = function(){
return "hi " + name;
}
}
var john = new Person("John");
alert(john.sayHi());
Comments
You can change like this:
function Person(name){
this.sayHi = function(){
return "hi " + name;
}
}
var john = new Person("John");
alert(john.sayHi());
Or something like this
function Person(name){
this.name = name;
}
Person.prototype.sayHi = function(){
return "hi " + this.name;
}
var john = new Person("John");
alert(john.sayHi());
Comments
Using an Object Constructor:
function Person(name){
this._name = name;
this.sayHi = function(){
return "hi " + this._name;
}
}
var john = new Person("John");
alert(john.sayHi());
Comments
Hi Please check this code
(function( $ ){
$.fn.sayHi = function(name) {
return name;
};
})( jQuery );
alert($('body').sayHi('dasd'));
Comments
For additional clarity you can take the sayhi method out of the Person Object declaration as below.
Declare Person Object, including name and sayhi function.
function Person(nameString){
this.name = nameString;
this.message = sayhi;
}
State what sayhi should do.
function sayhi(){
return hiString = "hi " + this.name;
}
Initiate your Person
var john = new Person("John");
Call sayhi function on your Person Object and alert the return value
alert(john.sayhi());
answered Jul 3, 2015 at 5:05
Daniel Hoffmann-Mitscherling
2,3691 gold badge18 silver badges23 bronze badges