Getting Segmentation Fault when passing pointer to pointer to a function

Question

When passing "pointer to pointer" to a function getting segmentation fault.Code is generating Binary search tree through insert function. Insert function is getting pointer to root node and a key value which it inserts at correct position

#include<iostream>
#include<stdlib.h>
strong text
using namespace std;

struct node
{
    int data;
    struct node* left;
    struct node* right;

};

void insert(struct node** node,int data)    
{
    if( *node == 0 )
    {
        (*node) = (struct node* ) malloc(sizeof(struct node));
        (*node)->data = data;
        (*node)->left = 0;
        (*node)->right = 0; 
    }
    else if(data < ((*node) -> data)){      
        insert((&((*node) -> left)),data);
    }
    else if(data > ((*node)->data)){
        insert((&((*node)->right)),data);
    }
}

void inordertreversal(struct node* node)
{
    inordertreversal(node->left);
    cout << node->data;
    inordertreversal(node->right);
}

int main()
{
    struct node *root = 0;
    insert(&root,10);
    insert(&root,6);
    inordertreversal(root);

    return 0;
}

Help much appreciated

0xAX · Accepted Answer · 2015-07-05 06:47:59Z

1

Check next nodes everytime:

void inordertreversal(struct node* node)
{
    if (node->left)
        inordertreversal(node->left);

    cout << node->data;

    if (node->right)
        inordertreversal(node->right);  
}

After this:

$ g++ example.c -o example && ./example
6
10

edited Jul 5, 2015 at 6:47

answered Jul 5, 2015 at 6:39

0xAX

22k26 gold badges123 silver badges211 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

nv3 Over a year ago

And I would add ''if (node == 0) return;'' at the beginning

commanche Over a year ago

Thanks , din't analyse properly inorder

Collectives™ on Stack Overflow

Getting Segmentation Fault when passing pointer to pointer to a function

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related