recursive method - not all code paths return a value!

Question

it says not all code paths return a value

private string Fisrt(string nonTerminal)
    {
        for (int j = 0; j < 6; j++)
        {
            if (Tokens[j, 0] == nonTerminal)
            {
                if (char.IsLower((char)Tokens[j, 3][0]))
                    return (Tokens[j, 3]);
                else
                    Fisrt(Tokens[j, 3]);
            }
        }
    }

it's declared in the function, a string value is returned but else is not returning a string value. add a return statement to the else.. — Chaitanya
– Chaitanya, Commented Jun 26, 2010 at 16:19

Dolph · Accepted Answer · 2010-06-26 17:38:41Z

1

private string Fisrt(string nonTerminal)
    {
        for (int j = 0; j < 6; j++)
        {
            if (Tokens[j, 0] == nonTerminal)
            {
                if (char.IsLower((char)Tokens[j, 3][0]))
                    return (Tokens[j, 3]);
                else
                    return Fisrt(Tokens[j, 3]);
                 /* ^ add a return here */
            }
        }

        return SOMETHING;
     /* ^ You also need to add some return value here */
    }

You also need to decide what string value (or null) to return in the event your for loop exits normally.

edited Jun 26, 2010 at 17:38

answered Jun 26, 2010 at 16:28

Dolph

50.9k13 gold badges66 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ken Over a year ago

What if Tokens[j,0]==nonTerminal is never true?

Lauri Lehtinen · Accepted Answer · 2010-06-26 16:20:32Z

1

For example, what if none of the Tokens[j, 0], with j values 0 to 5, is nonTerminal?

Or, if Tokens[j, 3][0] is never lowercase?

answered Jun 26, 2010 at 16:20

Lauri Lehtinen

10.9k2 gold badges34 silver badges30 bronze badges

Comments

Chubas · Accepted Answer · 2010-06-26 16:28:27Z

1

You should return the recursive step

`return First(Tokens[j, 3])`

and handle the cases outside the outer for and if.

answered Jun 26, 2010 at 16:28

Chubas

18.1k4 gold badges51 silver badges48 bronze badges

Collectives™ on Stack Overflow

recursive method - not all code paths return a value!

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related