Mysql query parameter issue in Perl

Question

Got a little problem in my code, the query works fine if I manually put values in. But failed if I use my variable. The code shows below

my $get_meter_id = $dbh->prepare("SELECT * from t_readings where meter_serial = '21001652' AND ...");
$get_meter_id->execute() or die "Couldn't execute statement: ".$get_meter_id->errstr;
my $meter_reg_id = $get_meter_id->fetchrow_array();

Above one works

where meter_serial = 21001652 AND ...")

Above one works.

where meter_serial = '".$variable."' AND ...")

Above doesn't work

where meter_serial = ".$variable." AND ...")

Above doesn't work

Many thanks.

prove it to yourself; use Data::Dumper; $Data::Dumper::Useqq=1; print Dumper($variable) — ysth
– ysth, Commented Jun 28, 2010 at 7:14
perhaps you could say what "failed" means? didn't select anything? gave an error? what error? — ysth
– ysth, Commented Jun 28, 2010 at 7:15

Quentin · Accepted Answer · 2010-06-28 05:30:31Z

7

Use placeholders. Don't fiddle about with string concatenation.

my $get_meter_id = $dbh->prepare("SELECT * from t_readings where meter_serial=? AND ...");
my $foo = 21001652;
$get_meter_id->execute($foo) or die "Couldn't execute statement: ".$get_meter_id->errstr;

answered Jun 28, 2010 at 5:30

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user180100 · Accepted Answer · 2010-06-28 05:29:50Z

5

What about:

my $get_meter_id = $dbh->prepare("SELECT * from t_readings where" .
     "meter_serial = ? AND ...");
$get_meter_id->execute($variable) or die "Couldn't execute statement: " . 
     $get_meter_id->errstr;
my $meter_reg_id = $get_meter_id->fetchrow_array();

Collectives™ on Stack Overflow

Mysql query parameter issue in Perl

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related