Angular JS adding a service to controller is not working

Question

I had this:

.controller('dashboardCtrl', function($scope, $timeout, $location, bionicoService, bionicoSamples, $state, $locale){

And everything worked fine, i could call my services for example bionicoSamples without a problem But i had to add a module for i18n and it requires this

.controller('dashboardCtrl', ['jlgI18nService', function( i18nService){

So when i added it to my code, my services stoped working, and i have no idea why, i'm king of new in angular and there is some conceptual stuff i don't understand well yet, for instance i really don't understand the difference betweem using "['module', function()" to "function('module')"

My code after trying to add the module is lilke this:

.controller('dashboardCtrl', ['jlgI18nService', function($scope, $timeout, $location, bionicoService, bionicoSamples, $state, $locale, i18nService){

I've also tried this, but is not working too

.controller('dashboardCtrl', ['jlgI18nService', '$scope', '$timeout', '$location', 'bionicoService',  '$state', '$locale', function($scope, $timeout, $location, bionicoService, bionicoSamples, $state, $locale, i18nService){

The error i'm getting is that my services are undefined, if i try to call bionicoSamples.function, it says that this ""function"" is not a function. I know the problem is in the way i'm importing the services and modules now with this i18n module, because before it was working fine

Thanks!

It sounds like a syntax error. Check your javascript console, an invaluable development tool. (In case Menu | Tools | Javascript console in case you're using chrome) — sabertiger
– sabertiger, Commented Jul 14, 2015 at 3:54

logee · Accepted Answer · 2015-07-14 03:54:00Z

1

From the angular docs when using 'Inline Array Annotation' to declare your controller

When using this type of annotation, take care to keep the annotation array in sync with the parameters in the function declaration.

The order that you're injecting your services is wrong and you have more inputs to your function than injected services. Should be something like this:

.controller('dashboardCtrl', [
    '$scope',
    '$timeout',
    '$location',
    'bionicoService', 
    'bionicoSamples', // This is missing in yours
    '$state',
    '$locale',
    'jlgI18nService',
    function($scope, $timeout, $location, bionicoService, bionicoSamples, $state, $locale, i18nService){

answered Jul 14, 2015 at 3:54

logee

5,0321 gold badge29 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Claies Over a year ago

this is correct, it is necessary that the order of services in the array match exactly the order of the function parameters.

Brenton Alker Over a year ago

Also worth noting - Because the parameters are position-based when using the array syntax, the names in the function parameters don't have to match (whether this is good or bad is debatable)

Collectives™ on Stack Overflow

Angular JS adding a service to controller is not working

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related