angular ionic $http service not working

Question

Loading json using $http isn't working. Can't figure out where the problem is

.factory('streamStore', function ($http) {
    var cachedData = null;

    return {
        findAll: function getAll() {
            $http.get('img/sample.json').
                success(function (data, status, headers, config) {
                    console.log("inside stream controller");
                    cachedData = data; return cachedData;
                }).
                error(function (data, status, headers, config) {
                    // log error
                });
        }

And in my controller this is how I'm calling it:

.controller('streamCtrl', function ($scope, ,streamStore) {
    $scope.streams = streamStore.findAll();//not working ,

show the error msz ?

ngLover
– ngLover

2015-07-16 13:58:43 +00:00
Commented Jul 16, 2015 at 13:58 — ngLover
– ngLover, Commented Jul 16, 2015 at 13:58
why not just returning data;

Vanojx1
– Vanojx1

2015-07-16 14:00:57 +00:00
Commented Jul 16, 2015 at 14:00 — Vanojx1
– Vanojx1, Commented Jul 16, 2015 at 14:00

Anil Sharma · Accepted Answer · 2015-07-16 14:24:47Z

1

There is a error in your code . Check below

.factory('streamStore', function ($http) {

 var cachedData = null;

 return {
    findAll: function() {
        $http.get('img/sample.json').
            success(function (data, status, headers, config) {
                console.log("inside stream controller");
                cachedData = data;
                return cachedData;
            }).
            error(function (data, status, headers, config) {
                // log error
            });
    }

and then call , as you were calling in your controller.

or use this

.factory('streamStore', function ($http) {

 var cachedData = function(){
     return $http.get('img/sample.json');
 };

 return {
    findAll: function(){
        return cachedData();
       }
    }

});

then in controller

streamStore.findAll().then(function(response){
     console.log(response) // here is your data
})

edited Jul 16, 2015 at 14:24

answered Jul 16, 2015 at 13:59

Anil Sharma

2,9625 gold badges32 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user46772 Over a year ago

i use the above method, replace the console log with $scope.streams i get a error -TypeError: streamStore.findAll(...).then is not a function at new <anonymous> (app.js:34) at Object.invoke (ionic.bundle.js:13012)

user46772 Over a year ago

tanks ,second method works can i pass argument to cachedata(userid) say to fetch spefic user id return cacheData(userid) along with the controller streamStore.findAll(userid)

Anil Sharma Over a year ago

yes you can do that and change your request type accrodingly

ngLover · Accepted Answer · 2015-07-17 11:36:14Z

1

since you have not returned anything from factory.

.factory('streamStore', function ($http) {
    var cachedData = null;

    return {
        findAll: function getAll() {
            $http.get('img/sample.json').
                success(function (data, status, headers, config) {
                    console.log("inside stream controller");
                    cachedData = data; return cachedData;

                     // should return something 
                     return cachedData
                }).
                error(function (data, status, headers, config) {
                    // log error
                });
        }

one more suggestion return promise to make it safe .

return $http.get('img/sample.json')...

and handle with then in controller.

.controller('streamCtrl', function ($scope, ,streamStore) {
   streamStore.findAll().then(function(res){
         //res will contain your data 
         $scope.streams =  res.data;
     });

edited Jul 17, 2015 at 11:36

answered Jul 16, 2015 at 14:04

ngLover

4,6183 gold badges23 silver badges42 bronze badges

1 Comment

user46772 Over a year ago

thanks for your suggesttion , the problem is im returning alot of function using the return { findAll,post,findOne ...} do u get the idea ,so i can call to any of the function in the controller ;

Collectives™ on Stack Overflow

angular ionic $http service not working

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related