Open links in loop - JavaScript

Question

I have written a script that opens always, more or less, the same link but with another ID. Which is the variable in the loop. My script looks actually like this and I would only like to know how I can open this link with the variable as an ID:

<!DOCTYPE html>
<html>
<body>

<button onclick="openLinks();">Click </button>

<script>
    function openLinks() {
        var i;

        for (i = 150; i < 156; i++) {
            window.open('http://www.someurl.at/wp-admin/admin.php?page=wpsl_store_editor&action=edit_store&store_id="i"'); //doesn't work, should print 150, 151...
        }
    }
</script>

</body>
</html>

That doesn't work. And no, the PopUp Blocker is no problem, I am using it for personal use and I deactivated the blocker for this html site — Andreas Schantl
– Andreas Schantl, Commented Jul 21, 2015 at 17:50
@epascarello Will a popup blocker will block it due to actions per time or due to many actions or due to window.open which is not via user click ( and if so , what about 2...n clicks)? — Royi Namir
– Royi Namir, Commented Jul 21, 2015 at 18:24

dhuang · Accepted Answer · 2015-07-21 17:49:05Z

1

It looks like you're not adding the variable as a string to your url.

Try something like this:

 window.open("http://www.ortner.elmima.at/wp-admin/admin.php?page=wpsl_store_editor&action=edit_store&store_id=" + String(i));

answered Jul 21, 2015 at 17:49

dhuang

9314 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sebastian Nette Over a year ago

That's not necessary at all.

dhuang Over a year ago

No problem. :-) @SebastianNette How so?

Sebastian Nette Over a year ago

@aznbanana9 Because you can concat strings and integers just fine. "text" + i is already a string. String(i) and ""+i pretty much do the same.

dhuang Over a year ago

Agreed, though for the sake of good practice, would you say it is better to explicitly call the global constructor String?

arm.localhost · Accepted Answer · 2015-07-21 17:47:31Z

0

If you put double quotes inside a single quote JS engine will understand it as a regular character not a variable. " and ' is string literals, however, you should use only one of them.

You should write something like this

var link = "someurl" + i;

answered Jul 21, 2015 at 17:47

arm.localhost

4995 silver badges10 bronze badges

Comments

epascarello · Accepted Answer · 2015-07-21 17:48:06Z

0

How would you build any normal string?

var x = "asdfg" + i;

so what you are doing is no different.

....tor&action=edit_store&store_id=' + i)

answered Jul 21, 2015 at 17:48

epascarello

208k20 gold badges206 silver badges246 bronze badges

Comments

Andreas Schantl · Accepted Answer · 2018-08-17 04:22:54Z

0

You have string/number concatenation problem :

Change :

 window.open('http://www.someurl.at/wp-admin/admin.php?page=wpsl_store_editor&action=edit_store&store_id="i"');

To

 window.open('http://www.someurl.at/wp-admin/admin.php?page=wpsl_store_editor&action=edit_store&store_id='+i);

The i within store_id="i"' is not dynamically evaluated.You have to "take out" the i as a string to a dynamic loop variable which concats to the string.

edited Aug 17, 2018 at 4:22

Andreas Schantl

1311 silver badge11 bronze badges

answered Jul 21, 2015 at 17:47

Royi Namir

149k145 gold badges502 silver badges833 bronze badges

Comments

Andreas Schantl · Accepted Answer · 2020-10-11 21:01:02Z

0

It should be

window.open('http://www.someurl.at/wp-admin/admin.php?page=wpsl_store_editor&action=edit_store&store_id="' + i + '"');

so that i does not render as part of a string, but rather to mean the variable.

edited Oct 11, 2020 at 21:01

Andreas Schantl

1311 silver badge11 bronze badges

answered Jul 21, 2015 at 17:48

limits

2954 silver badges12 bronze badges

Collectives™ on Stack Overflow

Open links in loop - JavaScript

5 Answers 5

4 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related