Mongoose: Array of objects not saving

Question

I'm trying to add object id to array in mongoose (Node.js). Here is my code:

app.post('/api/users/:userId/favorites/:objectId', function(req, res, next) {
    User.findByIdAndUpdate(req.params.userId, {$addToSet: {user_favorites: req.params.objectId}}, {safe: true, upsert: true}, function(err, data){
        if (err) return res.status(500).send(err)

        res.status(200).send({'message':'saved'});
    })
})

And here is my model:

module.exports = mongoose.model('User',{
    ...
    user_favorites: [{ type: mongoose.Types.ObjectId, ref: 'Property' }],
    ...
})

No errors are returned but the id is not added to the array. What am I missing?

You are also adding a string to the array/set. You need to convert it to an ObjectId. var id = mongoose.Types.ObjectId(req.params.objectId);. You'll want to verify the format of the user input as well, it must be a single String of 12 bytes or a string of 24 hex characters. That or catch the Error. — Matt
– Matt, Commented Jul 26, 2015 at 12:51

Blakes Seven · Accepted Answer · 2015-07-26 12:46:29Z

1

You forgot the "new" option. The .find**Update() methods have this turned off by default, which is the same behavior as the root method .findAndModfiy():

User.findByIdAndUpdate(
    req.params.userId, 
    { "$addToSet": {
      "user_favorites": req.params.objectId
    },
    { "upsert": true, "new": true },
    function(err, data){
        if (err) return res.status(500).send(err)

        res.status(200).send({'message':'saved'});
    }
)

So the document is actually updated in the database, but without "new" then you get the original document found, and not the modified one.

Also, whatever tutorial you learnt from, the "safe" option has been deprecated for a very long time. All write concern setting default to acknowleded, which is what that setting is supposed to represent.

answered Jul 26, 2015 at 12:46

Blakes Seven

50.5k14 gold badges132 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

adam Over a year ago

Wow, you are right. All the favorites were saved. Thanks for your help.

Collectives™ on Stack Overflow

Mongoose: Array of objects not saving

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related