Copying value of char pointer array to char array

Question

This is for a simple game and I am trying to learn how to apply C++ in an existing project (that's how I learn best), I have experience programming in C# and other high level languages so it is quite new to me still. So I have this list of races:

const char* Races[] = {
   "Demon",
   "Human",
   "Elf",
   "Orc",
   "Aliens"
};

At one point I receive the registration of a user and a race is selected. I save away all the information of the user to a struct and I want to save the full name of the race to this struct as well.

struct User_t {
   unsigned int RaceID;
   char Race[16];
};

The following code is what I got to put the values inside the struct:

User_t User;

User.RaceID = 3;
strcpy(User.Race, Races[User.RaceID]);

This, however, does not work. This is part of a game and the exception handling is horrible (it basically crashes the game without any error visible). I am trying to figure out what I am doing wrong. Any suggestions, perhaps suggestions on other things as well?

You'll find it much easier to use std::string and other classes rather than c-strings and structs. — The Forest And The Trees
– The Forest And The Trees, Commented Aug 5, 2015 at 10:37
As far as your shared code is considered, it is fine, i guess issue is somewhere else. — Nishant
– Nishant, Commented Aug 5, 2015 at 10:45

sbi · Accepted Answer · 2016-01-29 12:42:49Z

5

I am trying to figure out what I am doing wrong. Any suggestions, perhaps suggestions on other things as well?

You are trying to use C++ as if it was C (which is possible syntactically), and you do not know C nor C++ well enough to do that.

Do yourself a favor and do it in real C++:

std::string Races[] = {
   "Demon",
   "Human",
   "Elf",
   "Orc",
   "Aliens"
};

struct User {
  unsigned int RaceID;
  std::string Race;

  explicit User(unsigned int rid)
  : RaceID(rid)
  , Race(Races[rid])
  {}
};

User user(3);

std::cout << user.Race << '\n';

edited Jan 29, 2016 at 12:42

answered Aug 5, 2015 at 11:39

sbi

225k46 gold badges267 silver badges447 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Red-X · Accepted Answer · 2020-08-24 01:40:28Z

0

I would suggest that you look in to enum class{}. It's easier to make your code less error-prone.

You could write your code like this:

enum class eRaces
{
    eDemon,
    eHuman,
    eElf,
    eOrc,
    eAlien,
};

struct User
{
    eRaces myRace;
};

User User;

User.myRace = eRaces::eElf;

answered Aug 24, 2020 at 1:40

Red-X

891 gold badge1 silver badge14 bronze badges

Comments

Glapa · Accepted Answer · 2015-08-05 10:41:28Z

-1

Assuming that scope of Races array is global you can simply avoid copying it and just do something like this:

struct User_t {
   unsigned int RaceID;
   const char* Race;
};

User_t User;

User.RaceID = 3;
User.Race = Races[User.RaceID];

You can also use std::string as mentioned in comments but you wont avoid copying it. Since you develop game i think that performance has higher priority over objectivity of c++ language.

answered Aug 5, 2015 at 10:41

Glapa

80010 silver badges20 bronze badges

4 Comments

Quentin Over a year ago

Performance concerns about copying a ten-chars string once in the lifetime of a player ?

Roel Over a year ago

I actually decided not to copy the name over (performance related) and simply select the value from the char* array every time I need it. Thank you!

Glapa Over a year ago

@Quentin If object User is copied somewhere, it won't be once in the lifetime of a player. Overhead might be very small but in my opinion it's always better to take performance into consideration.

Quentin Over a year ago

Profiling is not really my domain, but this train of thought reeks of premature optimization.

Collectives™ on Stack Overflow

Copying value of char pointer array to char array

3 Answers 3

Comments

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related