AngularJS multiple $http calls, with multiple results

Question

I have a LIST of Id's and I want all of them to contact my API.

The way I did it is like this:

 var someFunct = function() {
      for (var i = 0; i < Apples.length; i++) {
       var Apple = Apples[i];
        $http.get("APIUrl" + Apple.Id).
        success(function (response) {
            for (var i = 0; i < response.Appleseeds.length; i++) {

                if(Apple.Appleseeds.Id == response.Appleseeds.Id)
                {
                    Apple.Size = response.Appleseeds.Size;
                }
            }               
        })

    }

So the problem is that Apple[2] has changed value, where Apple[0] and Apple[1] stay untouched. response.Appleseeds have their own list of Id's. So I need to change the Size of ALL THE APPLES not just Apple[2].

Dayan · Accepted Answer · 2015-08-06 11:49:01Z

5

You're close, use a closure instead:

var someFunct = function () {
    for (var i = 0; i < Apples.length; i++) {
        (function (Apple) {
            $http.get("APIUrl" + Apple.Id)
            .success(function (response) {
                for (var i = 0; i < response.Appleseeds.length; i++) {

                    if (Apple.Appleseeds.Id == response.Appleseeds.Id) {
                        Apple.Size = response.Appleseeds.Size;
                    }
                }
            });
        })(Apples[i]);
    }
};

Because http doesn't happen instantly, by the time the last success has happened in your code apple has been changed. By wrapping it in a closure you make it so that each call has it's own private Apple.

edited Aug 6, 2015 at 11:49

Dayan

8,10111 gold badges54 silver badges80 bronze badges

answered Aug 6, 2015 at 11:43

Mathew Berg

28.8k11 gold badges72 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

None Over a year ago

Its working! thank you ! in 3 min i give you "Correct answer" :D Need to read about closure..

gaurav bhavsar · Accepted Answer · 2015-08-06 11:53:22Z

1

var deferred = $q.defer();
var someFunct = function() {
  for (var i = 0; i < Apples.length; i++) {
    $http.get("APIUrl" + Apples[i].Id).
    success(function (response) {
         deferred.resolve(response)              
    })
    return deferred.promise;
 }
}

someFunct().then(function(d)){
    // write your code here
   }

answered Aug 6, 2015 at 11:53

gaurav bhavsar

2,0512 gold badges26 silver badges36 bronze badges

Collectives™ on Stack Overflow

AngularJS multiple $http calls, with multiple results

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related