javascript array push error in Safari Browser

Question

I got this error

SyntaxError: Unexpected token '}'. Expected a ':' following the property name 'value'.
(anonymous function)

when doing this :

var datas1 = [];
angular.forEach(data.data, function(value, key) {
            if(value.comfi_type_id == "1" || value.comfi_type_id == "3" || value.comfi_type_id == "4")
                datas1.push({value})
        })
        $timeout(function() {
            $scope.items = {'data':{'data1':datas1}};
          }, 1000);

The code run fine on Chrome, but only Safari appeared to be error. Can anyone enlighten me, what is wrong?

Question Update

After I doing this

datas1.push({value:value})

It is now run fine in Safari browser. But now when I tried on ios device (this is ionic app) the code is not functioning. No data is push inside datas1

I thought when everything work on Safari, also work on ios device ?

Razem · Accepted Answer · 2015-08-06 15:18:40Z

3

Safari probably doesn't support the short object notation ({ value }). You have to specify the key and the value:

datas1.push({ value: value });

answered Aug 6, 2015 at 15:18

Razem

1,46111 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Azizi Musa Over a year ago

That's great, it is working now. Will mark as answer later :)

Vale Over a year ago

@MiG I'd like to add that short object notation is an ES6 feature, so probably best to avoid using it directly if you plan to support multiple browsers.

Azizi Musa Over a year ago

Hi, I have update my question. The last fix run fine on Safari, but not yet in ios device. Why's that?

Razem Over a year ago

It should work. Is the condition fulfilled? Maybe there are some different data.

Azizi Musa Over a year ago

ahh yeah...I do platform remove ios then re-added, clean and rebuild on xcode. Everything is working fine now. Maybe I too panic :P ..thank you very much

jrh · Accepted Answer · 2015-12-29 14:33:10Z

2

I also had this issue. It was because, I was using

var newObj = [];
for (var k in dataArray) {
    newObj.push(datArr[k]);
}

This 'for-loop' creates issue only in Safari and it adds additionally a function object to the array and array length always actual length + 1.

I fixed by replacing this for loop with the below format,

var newObj = [];
for (var k = 0 ; k < dataArray.length; k++) {
    newObj.push(datArr[k]);
}

answered Dec 29, 2015 at 14:33

jrh

76413 silver badges33 bronze badges

Collectives™ on Stack Overflow

javascript array push error in Safari Browser

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related