Javascript - Faster, More Efficient Method for Sorting Javascript Object based on Sorted Array of _id?

Question

We have MongoDB docs that look like this:

var JavascriptObject = {
  DbDocs : [
    {
      _id : "1",
      {..more values..}
    },
    {
      _id : "2",
      {..more values..}
    },
    {
      _id : "3",
      {..more values..}
    }
  ]
}

Based on certain values in the JavascriptObject, we order an array of the _id from the documents, and the result is this:

var OrderedArray = [ 2, 1, 3 ];

Right now, we're rebuilding the entire JavascriptObject by matching the _id in the OrderedArray with the _id in DbDocs:

var JavascriptObjectToRebuild = [];
var DbDocuments = JavascriptObject.DbDocs;
var DocumentCount = 0;

for (var OrderedNumber in OrderedArray) {
  for (var Document in DbDocuments) {
    if ( DbDocuments[Document]._id === OrderedArray[OrderedNumber] ) {

      JavascriptObjectToRebuild[DocumentCount] = {}; // new Document Object

      JavascriptObjectToRebuild[DocumentCount]._id = DbDocuments[Document]._id;
      JavascriptObjectToRebuild[DocumentCount]...more values = DbDocuments[Document]...more values;

      DocumentCount++; // increment

    }
  }
}

var SortedJavascriptObject = { DbDocs: [] }; // format for client-side templating

for (var Document in JSONToRebuild) {
  SortedJavascriptObject.DbDocs.push(JavascriptObjectToRebuild[Document]);
}

Is there a faster more efficient way to sort the JavascriptObject based on this OrderedArray?

There is no JSON in this question at all. JSON is a textual notation. When you're dealing with objects and arrays in JavaScript, you're dealing with JavaScript objects and arrays. The only time you're dealing with JSON in JavaScript code is when it's inside a string. — T.J. Crowder
– T.J. Crowder, Commented Aug 7, 2015 at 7:05
Is there any reason you can't just call sort on JSON.DbDocs directly? — T.J. Crowder
– T.J. Crowder, Commented Aug 7, 2015 at 7:06
@Maji: I've updated my answer to show how to use OrderedArray with sort, but if you can implement the sorting logic directly rather than indirectly, it might be better. Obviously, that may not be possible or desireable for reasons outside the question... — T.J. Crowder
– T.J. Crowder, Commented Aug 7, 2015 at 7:15

Community · Accepted Answer · 2017-05-23 12:06:10Z

See update below if it's impossible to sort directly and you have to use OrderedArray instead.

If you can apply your criteria within the callback of the Array#sort function (e.g., if you can do it by comparing two entries in the array to one another), you can simply sort JSON.DbDocs directly.

Here's an example that sorts based on the numeric value of _id; naturally you'd replace that with your logic comparing objects.

Also note I've changed the name of the top-level variable (JSON is kinda in use, and in any case, it's not JSON):

var Obj = {
  DbDocs : [
    {
      _id : "2",
      more: "two"
    },
    {
      _id : "1",
      more: "one"
    },
    {
      _id : "3",
       more: "three"
    }
  ]
};
Obj.DbDocs.sort(function(a, b) {
  return +a._id - +b._id; // Replace with your logic comparing a and b
});
document.querySelector('pre').innerHTML = JSON.stringify(Obj, null, 2);

<pre></pre>

If it's impossible to sort directly and you have to work from OrderedArray, then it's still possible with sort, but it's less elegant: You use Array#indexOf to find out where each entry in the array should be:

Obj.DbDocs.sort(function(a, b) {
  return OrderedArray.indexOf(+a._id) - OrderedArray.indexOf(+b._id);
});

(The + converts the IDs from strings to numbers, since OrderedArray contains numbers in your question, but the ID values are strings.)

Live Example:

var Obj = {
  DbDocs : [
    {
      _id : "1",
      more: "one"
    },
    {
      _id : "2",
      more: "two"
    },
    {
      _id : "3",
       more: "three"
    }
  ]
};
var OrderedArray = [2, 1, 3];
Obj.DbDocs.sort(function(a, b) {
  return OrderedArray.indexOf(+a._id) - OrderedArray.indexOf(+b._id);
});
document.querySelector('pre').innerHTML = JSON.stringify(Obj, null, 2);

<pre></pre>

If there are going to be lots of entries in OrderedArray, you might want to make a lookup object first, to avoid lots of indexOf calls (which are costly: (georg did that in an answer, but he's since deleted it for some reason)

var OrderMap = {}
OrderedArray.forEach(function(entry, index) {
  OrderMap[entry] = index;
});
Obj.DbDocs.sort(function(a, b) {
  return OrderMap[a._id] - OrderMap[b._id];
});

(We don't need to convert the IDs to numbers because property names are always strings, so we've converted the numbers to strings when building the map.)

Live Example:

var Obj = {
  DbDocs : [
    {
      _id : "1",
      more: "one"
    },
    {
      _id : "2",
      more: "two"
    },
    {
      _id : "3",
       more: "three"
    }
  ]
};
var OrderedArray = [2, 1, 3];
var OrderMap = {}
OrderedArray.forEach(function(entry, index) {
  OrderMap[entry] = index;
});
Obj.DbDocs.sort(function(a, b) {
  return OrderMap[a._id] - OrderMap[b._id];
});
document.querySelector('pre').innerHTML = JSON.stringify(Obj, null, 2);

<pre></pre>

thanks for being thorough.. Obj.DbDocs.sort(function(a, b) { return OrderedArray.indexOf(+a._id) - OrderedArray.indexOf(+b._id); }); works like a charm

Oleksandr T. · Accepted Answer · 2015-08-07 07:21:54Z

1

As I understood, you want to get result like so,

[{"_id":"2"}, {"_id":"1"}, {"_id":"3"}]

so you can do it with one forEach and indexOf, like so

var JSONDADA = {
    DbDocs : [{_id : "1",}, {_id : "2"}, {_id : "3"}]
};

var DbDocuments = JSONDADA.DbDocs;
var OrderedArray = [ 2, 1, 3 ];
var result = [];

DbDocuments.forEach(function (el) {
    var position = OrderedArray.indexOf(+el._id);
    
    if (position >= 0) {
        result[position] = el;
    }
});
console.log(JSON.stringify(result));

answered Aug 7, 2015 at 7:21

Oleksandr T.

77.6k17 gold badges177 silver badges145 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:30:12Z

1

303 see other

......

Convert OrderedNumber into a hash _id => position:

sorter = {}
OrderedNumber.forEach(function(_id, pos) {
    sorter[_id] = pos
})

and then sort the target array by comparing id's positions:

DbDocuments.sort(function(a, b) {
    return sorter[a._id] - sorter[b._id];
})

edited May 23, 2017 at 12:30

CommunityBot

11 silver badge

answered Aug 7, 2015 at 7:13

georg

216k57 gold badges324 silver badges401 bronze badges

1 Comment

T.J. Crowder Over a year ago

Yeah, if OrderedArray is of any decent size, this is likely to make the sort more efficient.

Collectives™ on Stack Overflow

Javascript - Faster, More Efficient Method for Sorting Javascript Object based on Sorted Array of _id?

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related