CakePHP 2.7 save() failing with a single empty key in validationErrors

Question

Basically, I have a piece of code that looks like this:

$this->ModelName->id = $id;
$this->ModelName->save(
    array('ModelName'=>array(
        'boolean_column1'=>1,
        'boolean_column2'=>0,
        'string_column'=>'Some short string[always the same]'
)));

Sometimes this save fails. So I added the following:

debug($this->ModelName->validationErrors);
debug($this->ModelName->invalidFields());

And the results are:

########## DEBUG ##########
array(
    (int) 0 => array()
)
###########################
########## DEBUG ##########
array(
    (int) 0 => array()
)
###########################

When I set the "validate" param to false then this doesn't happen. I have also tried changing the save array in a way that doesn't have the 'ModelName' key, but it didn't help.

There aren't any beforeSave or afterSave callbacks, nor is there a $validate setting in this Model. There are more fields then there are being saved in this call, but this is updating an existing row in the database table.

This is code that runs cyclically in a Queue as part of an hour long cron job. I'm seeing different behaviours on different runs, which could be due to other queued functions changing something that causes issues, but I'm not seeing it, and it's difficult to find without a readable error message. This started happening after upgrading to 2.7.0 from 2.4.x and has worked fine since 1.3.x.

UPDATE 1: Ok, so I've updated the Model.php file to the version in the unreleased 2.8 branch, which includes a bugfix for 'atomic', and it's working now. If I manage to find out what was causing it precisely, I'll update here.

Please use real names, your model is not called Model (or if it is, that's problematic) and using that name is confusing. — AD7six
– AD7six, Commented Aug 7, 2015 at 15:21
It would be advisable to show us the code so we can help rather than assume that changing stuff around makes it just as easy. — Matt Stephens
– Matt Stephens, Commented Aug 7, 2015 at 15:34
@AD7six, fair enough. I've replaced it with "ModelName" which should make more sense. — Nick Zinger
– Nick Zinger, Commented Aug 7, 2015 at 15:34
@MattStephens this is part of a big codebase which I really can't all paste in here. These are the lines I've narrowed the issue down to, and I'm currently putting var_dumps within the Cake core to see where it fails to validate exactly. Also, I'm goint to try updating to 2.8.x to see if that changes anything, and report back. — Nick Zinger
– Nick Zinger, Commented Aug 7, 2015 at 15:36
@NickZinger The problem is that it might not be where you have narrowed it down too, no offence but sometimes as a developer you can overlook things. Are those 3 fields the only ones being saved there? — Matt Stephens
– Matt Stephens, Commented Aug 7, 2015 at 15:41

Nick Zinger · Accepted Answer · 2015-08-07 16:00:17Z

1

Ok, so I added this commit from the (at this moment) unreleased 2.8 branch which fixed it:

https://github.com/cakephp/cakephp/commit/c6e5026767e07585d43ff63de397535d652c18cc

From the commit message:

Fix issues saveMany & saveAssociated with boolean values. For non-atomic, save operations that include models with boolean fields. The first false value would cause the save to abort. This regression was introduced in #6947. Instead of checking the data from save() we should be boolean casting save() to capture the success/failure.

answered Aug 7, 2015 at 16:00

Nick Zinger

1,1741 gold badge12 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

CakePHP 2.7 save() failing with a single empty key in validationErrors

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related