Uncaught SyntaxError: missing ) after argument list when adding inside of php

Question

I have upated the question now. Below is the code which i stored in the external js file.

$js ='

var i=1;
var siteUrl = "http://'.$_SERVER['SERVER_NAME'].'";

$jd = jQuery.noConflict();
function dialog(urlvalue){
    $jd( "#dialog" ).dialog();
    alert("+urlvalue+");
}
$jd(document).ready(function(){
    var id = $jd(".product");

    id.each(function(index,element){
        //var productUrl = $jd(".product").attr("href");
        var productUrl = $jd("a:first-child ", this).attr("href");
        if(productUrl != undefined){
             //console.log(productUrl);
             productUrl = siteUrl + productUrl ; 
             //$jd(this).addClass("item-" + i);
             //console.log("checking"+index);
             $jd(".vm-product-media-container").addClass("view view-first");
             //console.log($jd(".js-recalculate input[name=pid]").val());
             $jd(".view-first", this).append("<button onclick=\"dialog("+productUrl+")\" class=sdlc_quick> Quick View</button>");       
             //console.log(productUrl);
         }
    });
})';
$doc->addScriptDeclaration($js);

I am getting an error missing argument when i clicked on the button quick view. Below is the code:-

$jd(".view-first", this).append("<button onclick=\"dialog("'+productUrl+'")\" class=sdlc_quick> Quick View</button>");

I can’t find any errors with JSHint as well. Maybe the error is at some other location. Do you have more JavaScript code in your PHP? — Sebastian Simon
– Sebastian Simon, Commented Aug 10, 2015 at 8:01
Apart from this script i have added only external js $doc->addScript('//code.jquery.com/ui/1.11.4/jquery-ui.js'); — don't know how to code
– don't know how to code, Commented Aug 10, 2015 at 8:05
You don't wrap your variable between quotes when you are calling the dialog() function. — Debflav
– Debflav, Commented Aug 10, 2015 at 8:07

Alex Tartan · Accepted Answer · 2015-08-10 08:27:29Z

2

Give this a try:

http://jsfiddle.net/7uyhr0vh/1/ (tried to understand the html structure, hope i got it right)

I mainly played with quotes and added a click event listener to the 'sdlc_quick' class

var i=1;
var siteUrl = "http://google.com";

$jd = jQuery.noConflict();

$jd(document).ready(function(){

    function dialog(urlvalue){
        $jd( "#dialog" ).dialog();
        alert(urlvalue);
    }

    var id = $jd(".product");
    id.each(function(index,element){
        var productUrl = $jd("a:first-child ", element).attr("href");
        if(productUrl != undefined){
            productUrl = siteUrl + productUrl ; 
            var x = $jd(".vm-product-media-container");
            x.addClass("view view-first");
            console.log(x)
            $jd(".view-first").append("<button class=\"sdlc_quick\"> Quick View</button>");
            $jd(".sdlc_quick",this).click(function(){
                dialog(productUrl);
            });
         }
    });
})

edited Aug 10, 2015 at 8:27

answered Aug 10, 2015 at 8:12

Alex Tartan

6,84410 gold badges37 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

don't know how to code Over a year ago

Well your answer was correct. i added it on my code and it was working correctly except one thing i am getting all the url in the alert. so i only modified one line:-$jd(".sdlc_quick",this).click(function() and it works fine

Alex Tartan Over a year ago

Updated my answer to include your observation. Thanks!

don't know how to code Over a year ago

Thanks for your help. now i able to understand and solved my issue

Collectives™ on Stack Overflow

Uncaught SyntaxError: missing ) after argument list when adding inside of php

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related