PHP - weird changes of variable value

Question

a have written this code:

<?php
require("../../config.php");
require("../php/funct.php");

try {
    $pdo = new PDO('mysql:host='.DB_HOST.';dbname='.DB_TABL.';', DB_AUSER, DB_APASS);
}
catch(PDOException $e) {
    echo 'Error: ' . $e->getMessage();
}
$idee=unique_id();
$insystem=true;

include('session_check.php');

unset($insystem);
    print($sesja);  ///// SECOND PRINT()
if($sesja!=1) {
    die("Session error");
    exit;
} else {    
       //some other code
}

session_check.php is here:

<?php
if(isset($insystem) && $insystem) {
    if(!isset($_COOKIE['seid']))    {
        setcookie('seid', $idee, time() + COOKIELIFE);
        $sesja=0;
    } else {
        setcookie('seid', $_COOKIE['seid'], time() + COOKIELIFE);
        $dane=$pdo->prepare('SELECT s.id, s.ip, s.czas, s.prawa, p.nick, p.id FROM sessions s JOIN pracownicy p ON s.Pracownicy_id=p.id WHERE s.id=:id');
        $dane->bindValue(':id',$_COOKIE['seid'], PDO::PARAM_STR);
        $dane->execute();
        $dsesji = $dane -> fetch();
        $dane->closeCursor();
        unset($dane);
        if($dsesji!==false) {
            if(isset($_GET['lo']) && ($_GET['lo']==='lo') && isset($indeks) && $indeks) {
                $usun=$pdo->prepare('DELETE FROM sessions WHERE id=:id');
                $usun->bindValue(':id',$_COOKIE['seid'], PDO::PARAM_STR);
                $usun->execute();
                unset($usun);
                setcookie('seid', 'abc', time() - 42000);
                header("Location: index.php");
            }
            $sesja=1;
            $_nick=$dsesji['nick'];
            $_Pracownicy_id=$dsesji['id'];
            $_prawa=explode('|',$dsesji['prawa']);
            unset($_prawa[count($_prawa)-1]);
            if($dsesji['ip']!=$_SERVER['REMOTE_ADDR']) {
                $usun=$pdo->prepare('DELETE FROM sessions WHERE id=:id');
                $usun->bindValue(':id',$_COOKIE['seid'], PDO::PARAM_STR);
                $usun->execute();
                unset($usun);
                setcookie('seid', 'abc', time() - 42000);
                header("Location: index.php?lo=bs");
                exit;
            }
            $teraz=time();
            $roznica=$teraz-$dsesji['czas'];
            if($roznica>(TIMEOUT*60)) {
                $usun=$pdo->prepare('DELETE FROM sessions WHERE id=:id');
                $usun->bindValue(':id',$_COOKIE['seid'], PDO::PARAM_STR);
                $usun->execute();
                unset($usun);
                setcookie('seid', 'abc', time() - 42000);
                header("Location: index.php?lo=to");
                exit;
            }
            if($sesja!=0) {
                $idee=unique_id();
                setcookie('seid', $idee, time() + COOKIELIFE);
                $dane=$pdo->prepare('UPDATE sessions SET id=:nowyid WHERE id=:id');
                $dane->bindValue(':nowyid',$idee, PDO::PARAM_STR);
                $dane->bindValue(':id',$_COOKIE['seid'], PDO::PARAM_STR);
                $dane->execute();
                unset($dane);
                $_CURR_SID=$idee;
                unset($idee);
            }
            print($sesja);  ///// FIRST PRINT()
        } else {
            $sesja=0;

        }
    }
} else {
    die('aerr1');
}
?>

Problem is: 1st print (from session_check.php) prints out 1 - what is expected value, but the second print in main script prints out 0 what is strange for me because $sesja variable is NOT changed between these both print's.

What's wrong?

Your code is too complicated, and it's difficult to track it. You should split it into several functions, and test each one of them separately. Also, try do use a debugger (it's not too difficult to setup): it's most helpful for situations like this. Czesc — Palantir
– Palantir, Commented Jul 7, 2010 at 12:43

spoulson · Accepted Answer · 2010-07-07 12:44:34Z

2

This happens because of variable scope within an include. $sesja was first set within your included code and lives only in there. When code execution returns to the main PHP script, $sesja is out of scope and forgotten.

To solve, you need to set $sesja = 0; somewhere before the include. Then, the included code will inherit scope and modify the correct variable.

answered Jul 7, 2010 at 12:44

spoulson

21.7k17 gold badges79 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP - weird changes of variable value

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related