onclick function SyntaxError: expected expression, got end of script

Question

I have script that append input to the page and the input with onclick function. This function get 3 parameters. But i get SyntaxError: expected expression, got end of script.

my code look like this:

scntDiv.append('<input id="coupon_id'+currentItem+'" type="button" value="Create Coupon" onClick="randomString(coupon_id'+currentItem+',ttt'+currentItem+',lll'+currentItem+');">');

Any Hellp?

argument inside randomString should be enclosed with quotation, I believe. — user5139444
– user5139444, Commented Aug 18, 2015 at 12:27
if i open firebug i see: onclick="randomString(coupon_id2,ttt2,lll2);" Instead of: onclick="randomString('coupon_id2','ttt2','lll2');" — pey22
– pey22, Commented Aug 18, 2015 at 12:34

Starfish · Accepted Answer · 2015-08-18 12:35:29Z

1

Your syntax was wrong at the end, here's the right version:

scntDiv.append('<input id="coupon_id'+currentItem+'" type="button" value="Create Coupon" onClick="randomString(\'coupon_id'+currentItem+'\',\'ttt'+currentItem+'\',\'lll'+currentItem+'\')">');

If you want to use ' you'll have to escape the character by using \ like: \'

edited Aug 18, 2015 at 12:35

answered Aug 18, 2015 at 12:28

Starfish

3,6441 gold badge24 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

pey22 Over a year ago

Thank you very much , Just what I needed.

Luan Nico · Accepted Answer · 2015-08-18 12:43:55Z

0

Though inline handlers work, it would be ideal to do something like this:

document.getElementById('coupon_id' + currentItem).onclick = function () {
    //your code here
};

Or, if you are using jQuery, just

$('coupon_id' + currentItem).on('click', function () { /* ... */ });

answered Aug 18, 2015 at 12:43

Luan Nico

6,0533 gold badges33 silver badges63 bronze badges

Collectives™ on Stack Overflow

onclick function SyntaxError: expected expression, got end of script

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related