Beginner - Java Programming While Loop

Question

This code keeps on looping every time I enter something. How to fix it?

public void inputPlayer()
{
    Scanner input = new Scanner(System.in);
    while(name.length() < 1)
    {
        System.out.println("Name: ");
        this.setName(input.nextLine());
        //name = input.nextLine();

        if(name.length() < 1)
            System.err.println("Must have one or more characters");
    }
}

Heres' a screenshot of the whole thing:

Unless this.setName changes name (don't know, you haven't given the code), nothing changes the guard condition, so it will never break. — Andy Turner
– Andy Turner, Commented Aug 20, 2015 at 8:01
@DanyalSandeelo have a look at the image he posted, theres everything. — JoshuadV
– JoshuadV, Commented Aug 20, 2015 at 8:04

Edd · Accepted Answer · 2015-08-20 08:04:39Z

5

The problem is visible in the screenshot, and is with your setName() method, which is currently:

public void setName(String newName) {
    newName = name;
}

The assignment is the wrong way around, so you never update your name field. It should be name = newName;.

answered Aug 20, 2015 at 8:04

Edd

3,8423 gold badges29 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Edd Over a year ago

@JoshuadV I'd have expected some angry IDE squiggles or the like, but in a simple class like that it stood out well enough regardless.

Paul Over a year ago

Beat me to it by a few seconds.

Google0593 Over a year ago

Hey edd thanks for your help! really appreciate it! :D

Hughzi · Accepted Answer · 2016-02-10 09:35:04Z

1

because your setName function is wrong

it should be:

    public void setName(String newName) {
        name = newName;
    }

you put newName = name;

edited Feb 10, 2016 at 9:35

answered Aug 20, 2015 at 8:07

Hughzi

2,5801 gold badge22 silver badges30 bronze badges

1 Comment

Google0593 Over a year ago

Hello hughzi! thanks for the help man! :D you guys are really fast at replying.

Collectives™ on Stack Overflow

Beginner - Java Programming While Loop

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related