Javascript array error

Question

I am trying to make one array equal another array like so: elementStyle[property] = styles[property];

But i keep getting a "invalid argument" error.

Any Ideas????

Addtional:

The code is on: http://prototypejs.org/assets/2009/8/31/prototype.js. The area that i'm interested in is:

setStyle: function(element, styles) {
  element = $(element);
  var elementStyle = element.style, match;
  if (Object.isString(styles)) {
    element.style.cssText += ';' + styles;
    return styles.include('opacity') ?
      element.setOpacity(styles.match(/opacity:\s*(\d?\.?\d*)/)[1]) : element;
  }
  for (var property in styles)
    if (property == 'opacity') element.setOpacity(styles[property]);
    else
      elementStyle[(property == 'float' || property == 'cssFloat') ?
        (Object.isUndefined(elementStyle.styleFloat) ? 'cssFloat' : 'styleFloat') :
          property] = styles[property];

  return element;
},

This code is fine in Firefox and Chrome, but not in IE. I get an invalid argument error.

Can you post the code? There are many possible options, and without seeing the code, you may never get the correct answer. — Oded
– Oded, Commented Jul 9, 2010 at 15:52
By all convention, as long as you have elements in your objects/arrays with the key/name of whatever is in property it should work. We'd need to see more code, but I imagine elementStyle or styles is either undefined or doesn't exist. — Andir
– Andir, Commented Jul 9, 2010 at 15:54
maybe you mean to say elementStyle['property'] = styles['property'] — txwikinger
– txwikinger, Commented Jul 9, 2010 at 16:02

Andir · Accepted Answer · 2010-07-12 10:46:32Z

4

Correct me if I'm wrong, but if you pass in an Object like an Array to styles, the for(var property in styles) will return functions and the conditions do not check for that.

You'll want to put in a check after your for:

for (var property in styles)
   if (typeof property == "string") // should filter out functions/objects/etc.

I'm not sure if this is what the cause of your error is though. I'm not sure what happens if you try assigning a function to the element.style.

edited Jul 12, 2010 at 10:46

answered Jul 12, 2010 at 10:40

Andir

2,0831 gold badge15 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Roki · Accepted Answer · 2010-07-09 18:52:03Z

el.style property is an object, not an Array... by the way in webkit it's not enumerable... If you try to iterate over style propertyes try it with a fixed list.

props = ('backgroundColor borderBottomColor borderBottomWidth borderLeftColor borderLeftWidth '+
        'borderRightColor borderRightWidth borderSpacing borderTopColor borderTopWidth bottom color fontSize '+
        'fontWeight height left letterSpacing lineHeight marginBottom marginLeft marginRight marginTop maxHeight '+
        'maxWidth minHeight minWidth opacity outlineColor outlineOffset outlineWidth paddingBottom paddingLeft '+
        'paddingRight paddingTop right textIndent top width wordSpacing zIndex').split(' ');
for (var i=0, len=props.length; i<len; i++) 
        element.style[props[i]] = styles[props[i]];

Another typical bug is that when you want to access border-bottom-width, you must replace /-([a-z])/g to uppercase letters...

Collectives™ on Stack Overflow

Javascript array error

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related