Changing renamed global variables from inside a function (python)

Question

I'm making a basic version of pokemon, and I have a function that looks like this:

global userhp, comphp
userhp = 100
comphp = 100

def doturn(attacker, enemy, move, attackerhp, enemyhp):
from random import randint
if move == 1:
    dmg = randint(18, 25)
    enemyhp -= dmg
    print("\t" + attacker, "have done", str(dmg), "damage")
    print("\t" + enemy, "now have", enemyhp, "health\n")
if move == 2:
    dmg = randint(8, 35)
    enemyhp -= dmg
    print("\t" + attacker, "have done", str(dmg), "damage")
    print("\t" + enemy, "now have", enemyhp, "health\n")
if move == 3:
    dmg = randint(15, 22)
    attackerhp += dmg
    print("\t" + attacker, "have healed", str(dmg), "health")
    print("\t" + attacker, "now have", attackerhp, "health\n")

Here is an example call:

doturn(user, comp, 3, userhp, comphp)

The problem I'm having is that changing attackerhp and enemyhp doesn't affect userhp and comphp. It stays at 100, and the game is unable to progress. I need a way of changing the global variables, but also doing it without hard-coding the variables into the function, because that way it would only work for the user or the computer.

I've been able to solve it, but my solution was to return the damage value and applying that to userhp and comphp outside this function. I could write separate functions for user and comp, or have an if statement check who's turn it is and do it that way, but I'd quite like to keep this compact. Any feedback would be appreciated.

That indentation doesn't make any sense.

khelwood
– khelwood

2015-08-23 14:16:02 +00:00
Commented Aug 23, 2015 at 14:16 — khelwood
– khelwood, Commented Aug 23, 2015 at 14:16

Dr Xorile · Accepted Answer · 2015-08-23 14:26:19Z

1

So you don't need to put the global statement in the first line. You only need that inside any function where you change the variable.

My understanding is that your issue is that the user or the computer could be either the attacker or the defender? Have I got this right?

In this case, why not make an object for attacker and defender, which stores their name and hp. That way, you can update attacker.hp and defender.hp inside the function without worrying about which is the user and which is the defender.

Something like this

class Player:
  def __init__(self, name, hp):
    self.name = name
    self.hp = hp

And get rid of the global variables altogether.

answered Aug 23, 2015 at 14:26

Dr Xorile

1,0141 gold badge9 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Changing renamed global variables from inside a function (python)

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related