AngularJS dependency-injection

Question

I have say two modules:

foo.a
foo.b

and an application module:

  angular.module("foo", ["foo.a","foo.b"])

I have a service in module foo.b say:

  angular.module("foo.b", [])

  angular.module("foo.b").factory("helper",helperFn);

which I want to use in one of my controllers in foo.a.

What I have done is simple dependency injection:

 angular.module("foo.a", []);

 angular.module("foo.a")
        .controller("MyController",["helper",MyControllerFn]);

which is working.

My questions are

How am I getting the "helper" service from module foo.b even though it is not declared as a dependency for module a?
Will it break at a later stage?
If it is correct, is this a good practice?

I am afraid you will get an error Error: [$injector:unpr] Unknown provider: helperProvider <- helper. Or put some JSFiddle to illustrate your issue. — Joy
– Joy, Commented Aug 25, 2015 at 4:48
the issue is that i am able to use a factory from other module without adding that module as a dependency plunker — Soham Nakhare
– Soham Nakhare, Commented Aug 25, 2015 at 6:42

Stafford Williams · Accepted Answer · 2015-08-25 04:29:47Z

7

Put the factory that you need access to in both modules in a third module. Have your two original modules inject a dependency to the third module.

angular.module("foo", ["foo.a", "foo.b"]);

angular.module("foo.a", ["foo.c"])
  .controller("MyController", ["helper", MyControllerFn]);

angular.module("foo.b", ["foo.c"]);

angular.module("foo.c")
  .factory("helper", helperFn);

answered Aug 25, 2015 at 4:29

Stafford Williams

9,8169 gold badges55 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

AngularJS dependency-injection

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related