Storing Rails model data in JavaScript arrays

Question

I am trying to get data from my model into JavaScript arrays, but this doesn't seem to be working.

<script type="text/javascript">
  var s_array = new Array();
  var img_array = new Array();
  var num_array = new Array();
  var x_array = new Array();
  var y_array = new Array();
  var p_array = new Array();

  <% @data.each do |data| %>
    s_array.push(<%= (data.s) %>);
    img_array.push(<%= (data.img) %>);
    num_array.push(<%= (data.num) %>);
    x_array.push(<%= (data.x) %>);
    y_array.push(<%= (data.y) %>);
    p_array.push(<%= (data.p) %>);
  <% end %>
</script>

For string you must use quotation like this line: s_array.push("<%= (data.s) %>"); — Tauhidul Islam
– Tauhidul Islam, Commented Aug 26, 2015 at 15:22
Why not just use JSON? That aside, not simply mirroring the data in the JS is already suspicious--why have separate arrays when you already have objects? — Dave Newton
– Dave Newton, Commented Aug 26, 2015 at 15:22
Same way you always do with JS? Your JSON would be the array of objects, thus JS objects, etc. Just dump the JSON string. — Dave Newton
– Dave Newton, Commented Aug 26, 2015 at 15:49

Heldraug · Accepted Answer · 2015-08-26 15:37:27Z

2

Don't print JS code in your views. That'll create a strong coupling between your front and back ends and it's ugly. If you want a simple approach, you can use a data tag and transform your model's data into JSON, which you can then simply consume in JS.

@data can be serialized using @data.to_json. If that's coming directly from the model, remember that you can override the as_json(options) method to control how the Active Record object gets rendered into a JSON object.

In your HTML, you can just add a data tag. For example, you could place this in your view:

<div id="data_model_name" data-your-data="<%= @data.to_json %>">

Back in JS, you can do:

var yourData = $('#data_model_name').data('your-data')

And retrieve the info.

answered Aug 26, 2015 at 15:37

Heldraug

2561 gold badge3 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Senju Over a year ago

Thanks, that makes sense

Collectives™ on Stack Overflow

Storing Rails model data in JavaScript arrays

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related