Javascript: "private" variables when using modules

Question

I am exporting a class where I do not want the user to be able to access the name variable. Is there anything wrong with doing it this way from a technical stand point, not personal preference? I know it's probably not a best practice, but it seems to work.

let _name = 'bob';
export default class Person {
  getName() {
    return _name;
  }

  setName(name) {
    _name = name;
  }
}

You've basically implemented a singleton.

Josh Beam
– Josh Beam

2015-08-31 19:31:21 +00:00
Commented Aug 31, 2015 at 19:31 — Josh Beam
– Josh Beam, Commented Aug 31, 2015 at 19:31
Try what happens with two instances.

Bergi
– Bergi

2015-08-31 19:52:30 +00:00
Commented Aug 31, 2015 at 19:52 — Bergi
– Bergi, Commented Aug 31, 2015 at 19:52

Ori Drori · Accepted Answer · 2015-08-31 19:30:15Z

2

The problem is simple - _name resides in a closure, and all instances of Person will set and get the same _name.

var a = new Person();
a.setName('John');

var b = new Person();
b.getName(); // the result will be John

answered Aug 31, 2015 at 19:30

Ori Drori

196k32 gold badges243 silver badges233 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

taxicala · Accepted Answer · 2015-08-31 19:30:05Z

0

Well, as what I see, my opinion is that _name is no longer private as per the code you've provided, because you are defining a getter and a setter method, which basically turns the variable to public.

You should also definitely take a look at @OriDrori's answer since he is right about the variable scope.

answered Aug 31, 2015 at 19:30

taxicala

21.8k7 gold badges41 silver badges67 bronze badges

Collectives™ on Stack Overflow

Javascript: "private" variables when using modules

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related