javascript code inside php echo

Question

This is my functional onClick script in HTML and it works perfectly:

<input type="text" id="t" name="t" value="1">
<a href="testar.php?action=" onclick="window.location=this.href+'&quant='+document.getElementById('t').value;return false;">Click</a>

What i want to achieve is this:

echo '<input type="text" value="1" id="t" name=""/>
<a href="addCarrinho.php?id_produto='.$registo['id'].'&nome='.$registo['nome'].'&preco='.$registo['preco'].'" onclick="window.location=this.href+'&quant='+document.getElementById('t').value;return false;">Add</a>';

All php works, i am receiving php variables on the other page but the onClick javaScript is not working, im getting a sintaxe error. I think its a quotes problem but im not familiarized with javaScript.

The syntax highlighting in your question shows you the problem - escape the single quotes there using a backslash — scrowler
– scrowler, Commented Sep 9, 2015 at 4:01

Mr. B · Accepted Answer · 2015-09-09 04:05:00Z

2

Change to the following:

<a href="addCarrinho.php?id_produto='.$registo['id'].'&nome='.$registo['nome'].'&preco='.$registo['preco'].'" onclick="window.location=this.href+\'&quant=\'+document.getElementById(\'t\').value;return false;">Add</a>';

answered Sep 9, 2015 at 4:05

Mr. B

2,9951 gold badge24 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

asdf · Accepted Answer · 2015-09-09 04:05:10Z

1

You need to escape the single quotes in the last line like following:

...
onclick="window.location=this.href+\'&quant=\'+document.getElementById(\'t\').value;return false;"
...

answered Sep 9, 2015 at 4:05

asdf

3,0872 gold badges24 silver badges43 bronze badges

Comments

Sameera Thilakasiri · Accepted Answer · 2015-09-09 04:05:27Z

0

echo '<input type="text" value="1" id="t" name=""/>
<a href="addCarrinho.php?id_produto='.$registo["id"].'&nome='.$registo["nome"].'&preco='.$registo["preco"].'" onclick="window.location=this.href+'&quant='+document.getElementById("t").value;return false;">Add</a>';

Try with this way, I did some single and double quote change.

answered Sep 9, 2015 at 4:05

Sameera Thilakasiri

9,51810 gold badges54 silver badges87 bronze badges

Collectives™ on Stack Overflow

javascript code inside php echo

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related