Java8 optional and null check

Question

I have following code:

final Optional<List<ServiceAttributeValue>> attributeValueList = Optional.<Product> of(product)
         .map(Product::getServiceAttributes)
         .map(ServiceAttributeMap::getMap)
         .map((v) -> (ServiceAttribute) v.get(attributeV.getAttributeString()))
         .map((c) -> (List<ServiceAttributeValue>) c.getValueList());

do I need to add check if v is null?

You probably don't need the .<Product> and you don't need the prentheses around single argument lambdas (you can replace (v) -> with v ->). — assylias
– assylias, Commented Sep 9, 2015 at 20:40

Sleiman Jneidi · Accepted Answer · 2015-09-09 20:12:45Z

2

First of all, your code is buggy. You using Optional to avoid NPE where your code will throw NPE if product is null. You should use Optional.ofNullable instead.

Optional.ofNullable(product)

and the answer is no, the third map will not get executed if ServiceAttributeMap::getMap returns null

answered Sep 9, 2015 at 20:12

Sleiman Jneidi

23.4k14 gold badges60 silver badges80 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tagir Valeev Over a year ago

Why do you think his product can be null? Author did not say so. See this question.

Collectives™ on Stack Overflow

Java8 optional and null check

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related