Why angularjs value do not change in app.run method

Question

I created some value named information and tried to edit it. How ever it is not effect in controller. Then, example in below not working.

(function () {
    var app = angular.module('app', []);

    app.value('information', []);

    app.run(['information', function (information) {
        information = [1, 2, 3, 4];
    }]);

    app.controller('myController', [
    '$scope', 'information', function ($scope, information) {
        $scope.inf = information;
    }]);
})();

<!DOCTYPE html>
<html>
<head>
    <title></title>
	<meta charset="utf-8" />
    <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.5/angular.min.js"></script>
    <script src="app.js"></script>
</head>
<body ng-app="app">
    <div ng-controller="myController">
        <p ng-repeat="i in inf">
            {{ i }}
        </p>
    </div>
</body>
</html>

try information.push(1, 2, 3, 4)

Grundy
– Grundy

2015-09-10 10:32:44 +00:00
Commented Sep 10, 2015 at 10:32 — Grundy
– Grundy, Commented Sep 10, 2015 at 10:32

Joy · Accepted Answer · 2015-09-10 10:41:13Z

2

Because when you inject information, it is a reference to the information object which is stored in Angular cache.

I do not recommend to modify the value from the controllers (although you can: JSFiddle).

You'd better use factory:

app.factory('information', function () {
    var info = [];
    return {
        get: function () {
            return info;
        },
        set: function (newInfo) {
            info = newInfo;
        }
    };
});

And inside your controller, use information.get() and information.set() to do the trick.

edited Sep 10, 2015 at 10:41

answered Sep 10, 2015 at 10:31

Joy

9,60011 gold badges50 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sahil gupta · Accepted Answer · 2015-09-10 10:41:58Z

1

You can use

Angular

(function () {
    var app = angular.module('app', []);

    app.value('information', []);

    app.run(['information', function (information) {
        information.push(1,2,3,4); //use this
    }]);

    app.controller('myController', [
    '$scope', 'information', function ($scope, information) {
        $scope.inf = information;
    }]);
})();

Refer plunker

edited Sep 10, 2015 at 10:41

answered Sep 10, 2015 at 10:17

sahil gupta

2,34914 silver badges14 bronze badges

Collectives™ on Stack Overflow

Why angularjs value do not change in app.run method

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related