Modify Django rest framework request

Question

My problem is how to write more strict API using more generic REST API. I have working api in my application but I need to add some more strict services based on generic API and here is a problem because I can't simple override request data because it's immutable. I'm using Django rest framework 3.

Example:

My generic api for animals:

class AnimalService(APIView):
    def get(self, request, *args, **kwargs):
        data = request.data.copy()
        if data.get('type') == 'dog':
            #...do something

Now I need api only for hardcoded dogs:

class DogService(AnimalService):
    def get(self, request, *args, **kwargs):
        #hardcode request.data['type'] = 'dog'
        return super(DogService, self).get(*args, **kwargs)

A better approach would be to use DRF permission classes and restrict the requests not having type as dog. — Rahul Gupta
– Rahul Gupta, Commented Sep 11, 2015 at 14:24
@RahulGupta yes but I don't need to client send me a type because I can hardcode it in my Dog service. Client don't have to know that I need 'type' in my rest view, so it's impossible to hardcode some arguments? — tstr
– tstr, Commented Sep 13, 2015 at 13:02

Rahul Gupta · Accepted Answer · 2015-09-13 16:38:05Z

1

Instead of overriding the request object, you can pass the type in kwargs. You can then use these kwargs in AnimalServiceView as these modified kwargs are passed to it.

class DogService(AnimalService):
    def get(self, request, *args, **kwargs):
        kwargs['type'] = 'dog' # set the animal type in kwargs
        return super(DogService, self).get(request, *args, **kwargs)

Then in your AnimalService view, you can do:

class AnimalService(APIView):
    def get(self, request, *args, **kwargs):
        if kwargs.get('type') == 'dog': # check the 'type'
            #...do something

Another way is to write a custom middleware which will set the animal_type attribute on the request depending on the requested resource. Then in your views, you can just check using request.animal_type attribute.

edited Sep 13, 2015 at 16:38

answered Sep 13, 2015 at 16:25

Rahul Gupta

48k12 gold badges120 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Modify Django rest framework request

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related