Using a function to build a Navigation from Database

Question

I'm trying to build a function which enables me to build a simple Navigation (or list, matter of fact) from a database table.

Problem is, the variables in the brackets don't work, how can I fix this?

function buildNav($DbRow, $DbName) {
  $nav_qry = "SELECT $DbRow FROM $DbName WHERE 1";
  $nav_res = mysqli_query($con, $nav_qry);
    echo "<ul>";
  while ($row = mysqli_fetch_assoc($nav_res)) {
    echo "<li id='" . $row[$DbRow] . "'><a href='?id=" . $row[$DbRow] . "' class='nav-point'>". $row[$DbRow] ."</a></li>";
  }
  echo "</ul>";
}

Thanks!

Onimusha · Accepted Answer · 2015-09-17 00:22:58Z

1

No need to make a new conenction to db. Just add the global variable thus:

function buildNav($DbRow, $DbName) {
    global $con;
    //...your sql code goes here
}

See http://php.net/manual/en/language.variables.scope.php

answered Sep 17, 2015 at 0:22

Onimusha

3,3842 gold badges28 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Hannes Irgendwas Over a year ago

Yeah, I just realized :)

CntkCtn · Accepted Answer · 2015-09-16 19:49:12Z

0

I assume you already checked if $nav_res has rows already. So, I suggest you to try the below code to see if it makes any difference.

while ($row = mysqli_fetch_assoc($nav_res)) { ?>
    <li id='<?php echo $row[$DbRow] ?>'><a href='?id=<?php echo $row[$DbRow] ?>' class='nav-point'><?php echo $row[$DbRow] ?></a></li>
<?php
  }
?>

answered Sep 16, 2015 at 19:49

CntkCtn

3572 silver badges7 bronze badges

3 Comments

Hannes Irgendwas Over a year ago

Thats not working :-/ <nav> <ul></ul> </nav>

CntkCtn Over a year ago

can you print_r the $nav_res please and also print_r the $row in the while.

Hannes Irgendwas Over a year ago

the print_r for $nav_res is 1, I'm not getting any for $row, in fact none of the echo commands I use inside the while-loop is printed, so its not iterating. But if I enter the query in phpmyadmin, I get results

Hannes Irgendwas · Accepted Answer · 2015-09-17 00:03:37Z

0

Allright the problem is, the function cannot access the $con variable defined earlier in the document, so If its in the function, the whole thing works.

function buildNav($DbRow, $DbName) {
  $con = mysqli_connect('host', 'user', 'password', 'database');
  $nav_qry = "SELECT $DbRow FROM $DbName WHERE 1";
  $nav_res = mysqli_query($con, $nav_qry);
    echo "<ul>";
  while ($row = mysqli_fetch_assoc($nav_res)) {
    echo "<li id='" . $row['title'] . "'><a href='?id=" . $row['title'] . "' class='nav-point'>". $row['title'] ."</a></li>";
      }
  echo "</ul>";
}

answered Sep 17, 2015 at 0:03

Hannes Irgendwas

457 bronze badges

Collectives™ on Stack Overflow

Using a function to build a Navigation from Database

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related