Recursively loop through a PHP array to manipulate data

Question

I'm trying to loop through a PHP array but I only ever get back my original data. I think it has something to do with when I break the loop

$newData = $this->seperateKeyValuePairs($data);

private function seperateKeyValuePairs($array)
{
    foreach($array as $key => $item)
    {
      if( is_array($item) ) $this->seperateKeyValuePairs($item);

      if( is_string($key) && $this->stringStartsWith($key, 'is_') ) {
        $item = $this->makeBoolean($item);
      }

    }

    return $array;
}

Uh, this doesn't make much sense. Can you a.) show us the array?, and 2.) tell us what you mean by " I only ever get back my original data" — Jay Blanchard
– Jay Blanchard, Commented Sep 17, 2015 at 20:28
You are setting $item to a value, but that doesn't update the original array. You probably want foreach($array as $key => &$item), so that way you're using references and the array will get updated. — gen_Eric
– gen_Eric, Commented Sep 17, 2015 at 20:29

Anders · Accepted Answer · 2015-09-17 21:05:08Z

1

I think the problem is on this line:

$item = $this->makeBoolean($item);

You change the value of item. Item is not a pointer to the value in the array, but a copy of it, so the value in the array remains unchanged. What you want to do instead is this:

$array[$key] = $this->makeBoolean($item);

In the same spirit, you have to change

if( is_array($item) ) $this->seperateKeyValuePairs($item);

to

if( is_array($item) ) $array[$key] = $this->seperateKeyValuePairs($item);

edited Sep 17, 2015 at 21:05

answered Sep 17, 2015 at 20:55

Anders

8,66310 gold badges60 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

WebDevDude Over a year ago

Thank you so much. That was the trick. I completely overlooked passing the reference.

Collectives™ on Stack Overflow

Recursively loop through a PHP array to manipulate data

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related