c malloc question

Question

#include<stdlib.h>
#include<stdio.h>

int main(){

 int row;
 int col;
 int i=1;
 double ** doubleNode;
 // *(*(doubleNode+row)+coln)
 doubleNode=malloc(sizeof(double)*4);
 *doubleNode=malloc(sizeof(double *)*4);


 for(row=0; row <4; row++){
   for(col =0; col<4;col++){
    *(*(doubleNode+row)+col)=i;
    i++;
   }
 }


free(doubleNode);
free(*doubleNode);
 return 0; 
}

this is a test code for a double pointer. it compiles fine with gcc, but when i run it. it gives me segmetation fault. do u know where i did wrong?

thanks

Vladimir · Accepted Answer · 2010-07-17 13:42:25Z

8

Memory for doubleNode must be allocated as a pointers to double and then you should allocate memory for each pointer in array:

doubleNode=malloc(sizeof(double*)*4);
for (int i = 0; i < 4;++i)
   doubleNode[i]=malloc(sizeof(double)*4);

The same applies to freeing the memory:

for (int i = 0; i < 4;++i)
   free(doubleNode[i]);
free(doubleNode);

answered Jul 17, 2010 at 13:42

Vladimir

171k36 gold badges392 silver badges313 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Dave O. Over a year ago

You were faster. Remind me to upvote Your answer tomorrow as I don't have any votes left today.

user50049 Over a year ago

@Dave - took care of that for you :)

Dave O. Over a year ago

@Nyan I recommend to use two-dimensional array rather than double indirect pointers - would have saved the OP form this trouble at all.

You · Accepted Answer · 2010-07-17 13:42:31Z

2

You are only mallocing the first "column" of your matrix. This row:

*doubleNode=malloc(sizeof(double *)*4);

is equivalent with this:

doubleNode[0]=malloc(sizeof(double *)*4);

You need to do this once for every column (or row). Additionally, I think the types in your sizeof statements should be reversed.

answered Jul 17, 2010 at 13:42

You

24k3 gold badges55 silver badges67 bronze badges

Comments

developmentalinsanity · Accepted Answer · 2010-07-17 13:41:53Z

1

I can see one problem immediately. You free doubleNode, then dereference it. Swap the two free's around.

Also, I think your mallocs are the wrong size. The first should be sizeof(double *) and the second sizeof(double).

Edit: And as others have said, you've only allocated the first "column" in your matrix.

answered Jul 17, 2010 at 13:41

developmentalinsanity

6,2792 gold badges25 silver badges18 bronze badges

Collectives™ on Stack Overflow

c malloc question

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related