spring RequestMapping not working without ModelAttribute

Question

I have controller class with following request mapping method.

appStart() method is responsible for redirecting user to login.html and logout() is responsible for invalidating session and redirecting user back to login.jsp
if I remove @ModelAttribute from their parameter then these two methods are throwing exception, is there any hack to get these methods working without modelattribute?

controller methods.

@RequestMapping(value="/",method=RequestMethod.GET) 
     public String appStart(@ModelAttribute("tempAdmin") Admin tempAdmin) {
    return "login.jsp";
}

@RequestMapping(method = RequestMethod.POST,name="doLogin")
public ModelAndView doLogin(@ModelAttribute("tempAdmin") Admin tempAdmin, HttpServletRequest request) {

    ModelAndView mvc = new ModelAndView();

    /*
        Buisness logic
    */

    mvc.setViewName("home.jsp");

    return mvc;
}

@RequestMapping("doLogout")
public String logout(HttpServletRequest request) {

    HttpSession session = request.getSession(false);
    if(session != null){
        session.invalidate();
    }

    return "login.jsp";
}

login.jsp

    <form:form action="doLogin" modelAttribute="tempAdmin" cssClass="form-horizontal">
      <div class="form-group">
          <label for="username" class="col-sm-2 control-label">Username</label>
       <div class="col-sm-10">
          <form:input cssClass="form-control" path="adminId" placeholder="username" />
        </div>
     </div>
    <div class="form-group">
         <label for="passwd" class="col-sm-2 control-label">Password</label>
    <div class="col-sm-10">
         <form:password path="password" cssClass="form-control" id="passwd" placeholder="password" />
    </div>
   </div>  
    <div class="form-group">
    <div class="col-sm-offset-2 col-sm-10">
      <button type="submit" class="btn btn-default">Sign in</button>
     </div>
   </div>
   </form:form>

stacktrace.

Caused by: java.lang.IllegalStateException: Neither BindingResult nor plain target object for bean name 'tempAdmin' available as request attribute
at org.springframework.web.servlet.support.BindStatus.<init>(BindStatus.java:144)
at org.springframework.web.servlet.tags.form.AbstractDataBoundFormElementTag.getBindStatus(AbstractDataBoundFormElementTag.java:168)
at org.springframework.web.servlet.tags.form.AbstractDataBoundFormElementTag.getPropertyPath(AbstractDataBoundFormElementTag.java:188)

There has to be an object named tempAdmin in the model, when using @ModelAttribute that is done automatic, else you have do it manual. So it isn't a hack it is basically how it is supposed to work. — M. Deinum
– M. Deinum, Commented Sep 23, 2015 at 7:08
return ModelAndView from other two methods i.e. appStart and logOut with newly created tempAdmin as modelAttribute — bsingh
– bsingh, Commented Sep 23, 2015 at 7:41
@M.Deinum But appStart() is to handle context-root and I am neither sending any data with a request and nor adding it in response. btw it is working fine with simple HTML form tags. — Govinda Sakhare
– Govinda Sakhare, Commented Sep 23, 2015 at 8:10
Ofcourse it is, but spring will do data binding and requires an underlying form object for that. — M. Deinum
– M. Deinum, Commented Sep 23, 2015 at 8:18
Not 100% sure, but it is worth a try adding BindingResult to your method signature. It must be added right after the ModelAttribute: public ModelAndView doLogin(@ModelAttribute("tempAdmin") Admin tempAdmin, BindingResult bindingResult, HttpServletRequest request) { — Fritz Duchardt
– Fritz Duchardt, Commented Sep 23, 2015 at 9:38

We are Borg · Accepted Answer · 2015-09-23 11:39:37Z

1

I will tell you how to change your controller, to avoid binding result problem. Try this :

@RequestMapping(method = RequestMethod.POST,name="doLogin")
public String doLogin(@ModelAttribute("tempAdmin") Admin tempAdmin, HttpServletRequest request,Model model) {
    model.addAttribute("tempadmin",new Admin());
    // business logic
    return "home";
}

Try this out, and if you have any other classes, then add the model.addAttribute for that as well. Can you post your JSP too?

answered Sep 23, 2015 at 11:39

We are Borg

5,31321 gold badges117 silver badges244 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Govinda Sakhare Over a year ago

you have misunderstood my question.issue is with appStart() and logout() method why do I need modelAttribute there? btw doLogin() is working perfectly fine,

We are Borg Over a year ago

Forget the @ModelAttribute in your appStart() and logout(), rest remains same. And why are you posting that controller method then if it's working fine??

Govinda Sakhare Over a year ago

dude I mean why do we even need that ModelAttribute in appStart() and logout() I binding nothing there and tempAdmin is useless there, these methods are for the redirecting purpose(redirecting to required jsp). I have posted doLogin() because tempAdmin is consumed by that method .

We are Borg Over a year ago

Like I said, FORGET the @ModelAttribute, and I am telling you to add a Model, not ModelAttribute, different stuff. Change the "tempadmin" to "tempAdmin".

We are Borg Over a year ago

Also, check stackoverflow.com/questions/32606019/… . Check the answer I have given, and check the main Post error... Arent they the same? you tell me.

|

Collectives™ on Stack Overflow

spring RequestMapping not working without ModelAttribute

1 Answer 1

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related