C# Array Method help

Question

Could some one please show me how I can rewrite the below method in a better and more elegant way?

// in class------------------

    public static void RefreshAllDropdownlists(DropDownList ddlRemoveUsersFromRole, DropDownList ddlAddUsersToRole, DropDownList ddlAddAllUsersToRole, DropDownList ddlRemoveAllUsersFromRole, DropDownList ddlDeleteAllUsersFromRole)
    {
        ddlRemoveUsersFromRole.ClearSelection();
        ddlAddUsersToRole.ClearSelection();
        ddlAddAllUsersToRole.ClearSelection();
        ddlRemoveAllUsersFromRole.ClearSelection();
        ddlDeleteAllUsersFromRole.ClearSelection();
    }

// in codebehind------------------

UserGvUtil.RefreshAllDropdownlists(ddlRemoveUsersFromRole, ddlAddUsersToRole, ddlAddAllUsersToRole, ddlRemoveAllUsersFromRole, ddlDeleteAllUsersFromRole);

Thank you!

Looks pretty good to me. What would you gain by rewriting the code? It does what you want. — Alastair Pitts
– Alastair Pitts, Commented Jul 18, 2010 at 23:03
@Alastair Pitts, with that code, the method will have to be modified every time he wants to refresh another DDL... — Thomas Levesque
– Thomas Levesque, Commented Jul 18, 2010 at 23:18

Thomas Levesque · Accepted Answer · 2010-07-18 23:55:39Z

7

Use the params parameter modifier to pass an array of DropDownLists :

public static void RefreshAllDropdownlists(params DropDownList[] dropDownLists)
{
    foreach (DropDownList ddl in dropDownLists)
    {
        ddl.ClearSelection();
    }
}

Usage is is the same as with your current method

edited Jul 18, 2010 at 23:55

answered Jul 18, 2010 at 23:05

Thomas Levesque

294k73 gold badges639 silver badges769 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

John Walsh Over a year ago

Awesome, thank you! This is exactly what I was aiming for but could not figure out the syntax.

Tion · Accepted Answer · 2010-07-18 23:25:21Z

var listsToRefresh = new List<DropDownList>
                {
                    ddlRemoveUsersFromRole,
                    ddlAddUsersToRole,
                    ddlAddAllUsersToRole,
                    ddlRemoveAllUsersFromRole,
                    ddlDeleteAllUsersFromRole
                };
listsToRefresh.ForEach(l=>l.ClearSelection());

There are many ways to do this, I would prefer this one. If all you are doing is performing ClearSelection() on each one, then there is no need to create a method for that one line of code. However, if you want to do some more work on each DropDownlist, then I think the use of an extension method would keep it elegant.

 public static class DropDownListExtensions
    {
        public static void Reset(this DropDownList dropDownList)
        {
            dropDownList.ClearSelection();
            //... do more stuff

        }
    }

listsToRefresh.ForEach(l=>l.Reset());

herzmeister · Accepted Answer · 2010-07-18 23:05:01Z

1

Something like

public static void RefreshAllDropdownlists(params DropDownList[] dropDownLists)
{
    if (dropDownLists != null)
        foreach (var ddl in dropDownLists)
            ddl.ClearSelection();
}

?

answered Jul 18, 2010 at 23:05

herzmeister

11.3k3 gold badges44 silver badges52 bronze badges

Comments

Russell · Accepted Answer · 2010-07-18 23:05:11Z

1

You could pass a list of DropDownList objects to the function, then you could do:

public static void RefreshAllDropdownlists(List<DropDownList> lists)
{
   foreach(DropDownList dropDown in lists)
   {
     dropDown.ClearSelection();
   }
}

answered Jul 18, 2010 at 23:05

Russell

17.8k24 gold badges84 silver badges127 bronze badges

Collectives™ on Stack Overflow

C# Array Method help

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related