Passing 2D array of pointers of string array to function in C

Question

I am trying to create a table of strings with 20 rows and 20 columns. It has following functions.

Insert values to cells in table
Concatenate 2 rows and replace to another row
Modify values in table

and some more operations

To do that I am trying to declare, pass and modify 2d strings i.e 2D array of char pointers. This is what I did. Below code contains only small portion of my code.

char *first_array[20][20]; //declared 2d array of pointers for storing a table of strings



int modify(char *array1[], char *array2[]) //here i want to pass 2 rows row 1 and row 2

{ 

int result1 = strcmp(array1[1], "~"); // here i want to access row 1 1st column for string operation

int result2 = strcmp(array2[1], "$");

return result1+result2;
}


int main() {

char *string = "hello";

strcpy(first_array[1][0], string); // insert values into table

strcpy(first_array[1][1], "~");

strcpy(first_array[2][0], string);

strcpy(first_array[2][1], "~");

printf("the result is %d\n", modify(first_array[1], first_array[2]); // pass row1 and row2

return 0;

}

Is this code correct ? Because Initially I was getting the error

expected ‘char **’ but argument is of type ‘const char **’

But I somehow corrected it and now I am getting segmentation fault. I am not able to get expected result.

Please provide me proper code for declaring, accessing, modifying and passing to functions of 2d array of char pointers/strings in C for above scenarios.

You should either allocate memory for first_array before using strcpy using malloc or just assign instead of strcpy. Note that you aren't supposed to modify the string if you are assigning. And don't forget to include stdlib.h and free the allocated memory if you are going for malloc. — Spikatrix
– Spikatrix, Commented Sep 27, 2015 at 8:25
@CoolGuy....Thank you for your help. I have edited my question. Looking for your answers. — nithesh1990
– nithesh1990, Commented Sep 28, 2015 at 5:25
I've rolled back your edit as it made the answers meaningless. If you have another question, post another question. — Spikatrix
– Spikatrix, Commented Sep 28, 2015 at 15:32

ameyCU · Accepted Answer · 2015-09-27 08:40:19Z

1

You should allocate memory to first_array using malloc and then do your desired operation .

Like this -

first_array=malloc(sizeof(char *)*2);       // here used 2 as you need 2 pointer right now
for(int i=1;i<3;i++){
      for(int j=0;j<2;j++){
            first_array[i][j]=malloc(strlen(string)+1);
      }
  }

Note- But remember to free allocated memory. And also don't declare it global if not necessary.

edited Sep 27, 2015 at 8:40

answered Sep 27, 2015 at 8:31

ameyCU

16.7k2 gold badges28 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

orestiss · Accepted Answer · 2015-09-27 09:03:08Z

0

With your first declaration char *first_array[20][20], you are creating a global 2d array, and allocating memory for it, to the part of the memory that global variables are stored.

So you have an array of pointers, but were are they pointing at? You then have to allocate memory for your strings, and give to the pointers in your array an address to a string location.

You can not use strcpy() because your pointer is not pointing to anything yet, it may hold a garbage value though and so producing a segfault trying to access a memory address that doesn't exist or is used.

answered Sep 27, 2015 at 9:03

orestiss

2,2932 gold badges21 silver badges24 bronze badges

Collectives™ on Stack Overflow

Passing 2D array of pointers of string array to function in C

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related