how to read a variable inside service in angularjs?

Question

I want to know how can I get the value of a variable that is inside a service, I have the following code:

myModule.service('notify', ['$window', function(win) {  
       var msgs = []; // I want to read this variable
       this.message = function(msg) {
         msgs.push(msg);
         if (msgs.length == 3) {
           win.alert(msgs.join("\n"));
           msgs = [];
         }
       };
     }]);

and I want to read the msgs variable from a controller.

@SheraliTurdiyev, The fact that the message method is mutating the msgs array is indeed undesired and should be avoided. Yet, exposing msgs using a method precisely answers the question. — haim770
– haim770, Commented Sep 30, 2015 at 21:12

Hampus · Accepted Answer · 2015-09-30 20:26:54Z

Declaring variables with var makes them local to the scope of the function. If you want to expose it you can store it on the object itself.

myModule.service('notify', ['$window', function(win) {  
   this.msgs = []; // I want to read this variable
   this.message = function(msg) {
     this.msgs.push(msg);
     if (this.msgs.length == 3) {
       win.alert(this.msgs.join("\n"));
       this.msgs = [];
     }
   };
 }]);

Then you can retrieve msgs on your service by reading

service.msgs

A better pattern would be to create a getter method to retrieve the messages.

myModule.service('notify', ['$window', function(win) {  
   var msgs = []; // I want to read this variable
   this.getMessages = function () {
     return msgs;
   };
   this.message = function(msg) {
     msgs.push(msg);
     if (msgs.length == 3) {
       win.alert(msgs.join("\n"));
       msgs = [];
     }
   };
 }]);

Then you can retrieve your messages by calling

service.getMessages();

David L · Accepted Answer · 2015-09-30 20:23:16Z

3

Services are created with new and as a result will expose whatever is attached to this. Simply add a function that returns your messages array to this.

myModule.service('notify', ['$window', function(win) {  
    var msgs = []; // I want to read this variable

    this.message = function(msg) {
        msgs.push(msg);

        if (msgs.length == 3) {
            win.alert(msgs.join("\n"));
            msgs = [];
        }
    };

    this.getMessages = function () {
        return msgs;
    }
 }]);

answered Sep 30, 2015 at 20:23

David L

34.1k8 gold badges70 silver badges98 bronze badges

Comments

Sherali Turdiyev · Accepted Answer · 2015-09-30 22:15:42Z

0

1. You can use getter for reading

myModule.service('notify', ['$window', function (win) {
    var msgs = [];// I prefer _msgs for private variables
    Object.defineProperties(this, {
        msgs: {
            get: function () {
                return msgs;
            },
            /*set: function (val) {
                msgs = val;
            },*/ //if you need setter uncomment
            enumerable: true
        }
    });
    //other codes....
}]);

Then, you can use console.log(notify.msgs); in controller

edited Sep 30, 2015 at 22:15

answered Sep 30, 2015 at 20:49

Sherali Turdiyev

1,75316 silver badges29 bronze badges

Collectives™ on Stack Overflow

how to read a variable inside service in angularjs?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related