How to add switch statement inside array of type class?

Question

I have requirement where based on the certain condition only, i need to initialize the array of type class. So i'm trying insert switch statement inside the array of type class as below.

 for (int i=0;i <testChildData.size();i++ )
        {
            switch (testChildData.get(i)) {
                SyncPreferenceItem[] syncCategoryList = {
                case "VISIT":
                    new SyncPreferenceItem(R.drawable.sync_visit, R.string.PrefVisits,
                            SynchronizationManager.SYNC_CATEGORY_TYPE.VISITS);
                    break;
                case "CUSTOMERS":
                    new SyncPreferenceItem(R.drawable.sync_customer, R.string.Customers,
                            SynchronizationManager.SYNC_CATEGORY_TYPE.CUSTOMERS);
                    };
            }
}

But i'm getting an error. Could you please point me in the right direction or any other logic for the same. Thank you

Could you post the error you're getting?

Aidan Gomez
– Aidan Gomez

2015-10-01 04:21:53 +00:00
Commented Oct 1, 2015 at 4:21 — Aidan Gomez
– Aidan Gomez, Commented Oct 1, 2015 at 4:21
What is the error. Where you declare the array ?

Viswanath Lekshmanan
– Viswanath Lekshmanan

2015-10-01 04:27:22 +00:00
Commented Oct 1, 2015 at 4:27 — Viswanath Lekshmanan
– Viswanath Lekshmanan, Commented Oct 1, 2015 at 4:27

YoungHobbit · Accepted Answer · 2015-10-01 04:39:21Z

3

Assumption: For each value you will add the object of SyncPreferenceItem.

You can add a break statement after the second case statement. Even though it is not a requirement here, because you don't have anything else after that case statement. But can save you from future errors.

Declare and initialize array outside for loop and add the object using switch.

syncCategoryList = new SyncPreferenceItem[testChildData.size()];
for (int i=0;i <testChildData.size();i++ ) {
  switch (testChildData.get(i)) {
    case "VISIT":
      syncCategoryList[i] = new SyncPreferenceItem(R.drawable.sync_visit, R.string.PrefVisits,
          SynchronizationManager.SYNC_CATEGORY_TYPE.VISITS);
      break;
    case "CUSTOMERS":
      syncCategoryList[i] =  new SyncPreferenceItem(R.drawable.sync_customer, R.string.Customers,
          SynchronizationManager.SYNC_CATEGORY_TYPE.CUSTOMERS);
      break;
  }
}

If you are not sure how many object you are going to create inside the for loop then use ArrayList instead of simple array of SyncPreferenceItem;

List<SyncPreferenceItem> syncCategoryList = new ArrayList<>();

  for (int i=0;i <testChildData.size();i++ ) {
    switch (testChildData.get(i)) {
      case "VISIT":
        syncCategoryList.add(new SyncPreferenceItem(R.drawable.sync_visit, R.string.PrefVisits,
            SynchronizationManager.SYNC_CATEGORY_TYPE.VISITS));
        break;
      case "CUSTOMERS":
        syncCategoryList.add(new SyncPreferenceItem(R.drawable.sync_customer, R.string.Customers,
            SynchronizationManager.SYNC_CATEGORY_TYPE.CUSTOMERS));
      break;
    }
  }

edited Oct 1, 2015 at 4:39

answered Oct 1, 2015 at 4:24

YoungHobbit

13.4k9 gold badges53 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

coders Over a year ago

Hello Hobbit, Thanks a lot for replying. I will check and let you know

akhil_mittal Over a year ago

The case statement is missing break.

YoungHobbit Over a year ago

@akhil_mittal the last statement need not to have break statement. because there is nothing afterwards.

akhil_mittal Over a year ago

Well technically yes. But it does do any harm to provide break for case 2 if someone adds a next case later on that will come handy. Also default is missing which can create hard-to-find bugs in future.

YoungHobbit Over a year ago

@akhil_mittal dude this is what the OP needs. Also even default is also missing what do you say about that. Should I add an UnSupportedException for that?

|

akhil_mittal · Accepted Answer · 2015-10-01 04:40:49Z

1

The structure is wrong as correct structure would be:

SyncPreferenceItem[] syncCategoryList = new SyncPreferenceItem [testChildData.size];
for (int i=0;i <testChildData.size();i++ ) {
    switch (testChildData.get(i)) {
        case "VISIT":
            syncCategoryList[i] = new SyncPreferenceItem(R.drawable.sync_visit, R.string.PrefVisits,
                    SynchronizationManager.SYNC_CATEGORY_TYPE.VISITS);
            break;
        case "CUSTOMERS":
            syncCategoryList[i] = new SyncPreferenceItem(R.drawable.sync_customer, R.string.Customers,
                    SynchronizationManager.SYNC_CATEGORY_TYPE.CUSTOMERS);
            break;
    }
}

There are following points worth noting:

All elements in the array has to be of type SyncPreferenceItem.
The size of the array would be testChildData.size.
Every case statement should have a break else control will skip to next case.
In case no of items are dynamic it is better to use ArrayList.
The default case is missing in the code of OP that should also be added becuase there is no guarantee that inputs to switch will always be VISIT and CUSTOMERS. If anything else goes in there needs to be some code to handle that default case as well.

edited Oct 1, 2015 at 4:40

answered Oct 1, 2015 at 4:28

akhil_mittal

24.3k8 gold badges99 silver badges97 bronze badges

1 Comment

coders Over a year ago

Thanks Akhil for replying me back. Sure i will look after the points which you have suggested.

Collectives™ on Stack Overflow

How to add switch statement inside array of type class?

2 Answers 2

10 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related