angular js access variable in a service but same app

Question

How can I access a property of a controller in a service?

In my case it is an array, which I want to change in my service.

My controller:

myApp.controller('MainController', function ($scope, $interval, externalDataService, AnalyzeService) {
    $scope.myArray = [];
    var size = 10;

    var analyze = function () {
       if($scope.myArray .length > size) {
          AnalyzeService.doSomething();
       }
    };

    var analyzeData = function () {
        externalDataService.getData().then(function (data) {
            $scope.faceReaderData.push(data);
            analyze();
         });
     };

    $interval(analyzeData , 2000);
});

My service:

myApp.service('AnalyzeService', function () {
    this.doSomething = function () {
        //here i want array access
    }
});

You can just pass the array into your service function as a parameter. — muenchdo
– muenchdo, Commented Oct 1, 2015 at 9:45
In my case I want make changes in the array, Like delete the first 10 Objects. If I pass the array into the service as a parameter i have to return it and set it as new array. And that´s what i dont want to — trap
– trap, Commented Oct 1, 2015 at 9:52

LionC · Accepted Answer · 2015-10-01 10:03:31Z

1

You do not want to do that, as it would make your service depend on your controller, which is very undesireable. Instead, add the array as a parameter to your doSomething:

//Appending 1,2,3 to the given array
function doSomething(someArray) {
    return someArray.concat(['1', '2', '3']);
}

This way, your service does not depend on your controller at all, seperating your business logic from your controller.

edited Oct 1, 2015 at 10:03

answered Oct 1, 2015 at 9:51

LionC

3,1061 gold badge24 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

angular js access variable in a service but same app

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related