Android getting JSONObject Exception

Question

I'm getting a JSONObject Exception in cases where the twitter value in my JSON Object media is null in my below code, even though I check to make sure I'm not assigning the value to anything if it is. Is the way I am checking correct? or how can I avoid my code throwing the exception and allow me to check if the twitter value is there or not?

if(nextActivityObject.getJSONObject("media") != null){

    media = nextActivityObject.getJSONObject("media");
    Log.d("NEXT MEDIA OBJECT NOT EMPTY", media.toString());

    if(media.getString("twitter") != null &&  media.getString("facebook") != null){
         Log.d("BOTH NOT NULL", "both not null");
         twitter = media.getString("twitter");
         facebook = media.getString("facebook");

          intent.putExtra("twitter", twitter);
          intent.putExtra("facebook", facebook);
      }
      else if(media.getString("twitter") != null){

           twitter = media.getString("twitter");
           Log.d("JUST TWITTER NOT NULL", twitter.toString());
           intent.putExtra("twitter", twitter);
      }
      else if(media.getString("facebook") != null){
          facebook = media.getString("facebook");
          Log.d("JUST FACEBOOK NOT NULL", facebook.toString());
          intent.putExtra("facebook", facebook);
      }
  }

timrau · Accepted Answer · 2015-10-03 03:24:29Z

1

You can use media.optString("twitter");. And you need another media.has("twitter") to distinguish between "no key called twitter" and "twitter key has empty string value".

To sum up, for "twitter" key, you could write

 else if(media.has("twitter")){
       twitter = media.optString("twitter");
       // here twitter is non-NULL String
       Log.d("JUST TWITTER NOT NULL", twitter.toString());
       intent.putExtra("twitter", twitter);
  }

edited Oct 3, 2015 at 3:24

answered Oct 3, 2015 at 3:12

timrau

23.1k4 gold badges55 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Rafa Over a year ago

I tried media.optString("twitter") and had no luck. I checked my JSON object response and in the cases where it crashes the value is {'facebook' : ....'} and no twitter, so in that case I would use the .has to check for that "no key" case?

timrau Over a year ago

@ralphie9224 I've summarized again in the answer. Use opt*() instead of get*() to change exception handling to null reference / empty string / NaN value checking.

Jiju Induchoodan · Accepted Answer · 2015-10-03 04:08:44Z

1

Use .has method to find out whether the key is in json or not. Instead of getString it is wise to use optString.

answered Oct 3, 2015 at 4:08

Jiju Induchoodan

4,2661 gold badge24 silver badges26 bronze badges

Collectives™ on Stack Overflow

Android getting JSONObject Exception

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related