error outputting file with python 3.0

Question

I am not sure why I am receiving this error. Everything in my program seems to be working perfectly. the program is basically a simple administration system to store username and password accounts.

the error i get is, ValueError: I/O operation on closed file.

the program successfully writes the first account, but the other accounts do not get stored in the .txt file

here is my code where i am getting the error

if savedata == 'y': 
print ("\nData Successfuly Saved!")
filehandle = open(filename, "r+")

    for username, password in store_data.items():
        print(username, ":",password)
        password = password.replace("\n","")
        filehandle.write(username) # it says this line is my error
        filehandle.write(":") 
        filehandle.write(password)
        filehandle.write("\n")
        filehandle.close()  

   else:
 ("Exiting Application Terminal...")

Martin Evans · Accepted Answer · 2015-10-07 06:14:53Z

1

The following should fix matters:

if savedata == 'y': 
    print ("\nData Successfully Saved!")

    with open(filename, "w") as filehandle:
        for username, password in store_data.items():
            print(username, ":", password)
            password = password.replace("\n","")
            filehandle.write("{}:{}\n".format(username, password))
else:
    print("Exiting Application Terminal...")

You were closing the file after each iteration, as you only opened it once, this is why only one entry was saved.

It is also safer to use Python's with construct which will automatically take care of closing the file for you.

If you wish to append to an existing file, use "a" as the mode.

answered Oct 7, 2015 at 6:14

Martin Evans

46.9k17 gold badges88 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

agold · Accepted Answer · 2015-10-07 05:42:44Z

0

You should open the file for writing:

filehandle = open(filename, "w")

answered Oct 7, 2015 at 5:42

agold

6,3069 gold badges41 silver badges56 bronze badges

Collectives™ on Stack Overflow

error outputting file with python 3.0

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related