PHP / MySQL: Login form doesn't work

Question

I've got a login.php file which looks like this:

include "myfuncs.php";

$connect = dbConnection();

$username = $_POST["username"];
$passwort = md5($_POST["password"]);

$query = "SELECT username, password FROM user WHERE username LIKE '$username' LIMIT 1";
$ergebnis = mysql_query($query);
$row = mysql_fetch_object($result);

if($row->password == $passwort)
{
    echo "Hi $username";
    $_SESSION["username"] = $username;

    echo "Login successfully";
}
else
{
    echo "Login doesn't work";
}

and a myfuncs.php file which looks like this:

function dbConnection()
{
$servername = "...";
$username = "...";
$password = "...";
$dbname = "...";

$db_connect = new mysqli($servername, $username, $password, $dbname);

    if ($db_connect->connect_error) 
    {
        die("Connection failed: " . $db_connect->connect_error);
    }
    return $db_connect;
}

Unfortunately the login form doesn't work - it always gives the error "Login doesn't work" even when the username and password matches with the database entry.

You are mixing mysql_ and mysqli_ functions. You connect using mysqli, but then run checks using mysql_ functions, which does not know about your mysqli_ connection. Update everything to their mysqli counterparts. — Oldskool
– Oldskool, Commented Oct 15, 2015 at 9:00
@coder No, the other way around. mysql_ functions have been deprecated for a few years now, you should really avoid them as they will be dropped with the upcoming PHP7 release later this year. So use mysqli_ functions for everything. — Oldskool
– Oldskool, Commented Oct 15, 2015 at 9:04

ThinkTank · Accepted Answer · 2015-10-15 09:07:34Z

1

Arg, you are mixing a mysqli with class mysql functions. I dont think it works...

It works this way : PHP MySQLI

$stmt = $mysqli->prepare($query)

while ($stmt->fetch()) {
    (...)
}

answered Oct 15, 2015 at 9:07

ThinkTank

1,1919 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

CorpPlus · Accepted Answer · 2015-10-15 09:03:19Z

0

I see you have error in your variable name in line #6. try this:

$query = "SELECT username, password FROM user WHERE username LIKE '$username' LIMIT 1";
$result= mysql_query($query);
$row = mysql_fetch_object($result);

answered Oct 15, 2015 at 9:03

CorpPlus

73 bronze badges

Comments

Lucrian · Accepted Answer · 2015-10-15 09:09:35Z

0

There are several problems with your code. In myfuncs.php you use mysqli and after that, in your code you use mysql (without "i"). mysql (without "i") is deprecated, so you should use mysqli everywhere.

More than that, in your code you have:

$query = "SELECT username, password FROM user WHERE username LIKE '$username' LIMIT 1";
$ergebnis = mysql_query($query);
$row = mysql_fetch_object($result);

Please see the bold text from next two lines (it should be the same variable):

$ergebnis = mysql_query($query);

$row = mysql_fetch_object($result);

You should have

$result = mysql_query($query);

if you will use mysql.

answered Oct 15, 2015 at 9:09

Lucrian

1

Collectives™ on Stack Overflow

PHP / MySQL: Login form doesn't work

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related