Use global variable in ASP.NET MVC

Question

First look at the sample controller code. There you'll find two statements which are repetitive-

public class DashboardController : Controller
{
    //the following line is repetitive for every controller.
    String ConnectionString = WebConfigurationManager.ConnectionStrings["MyConnectionString"].ConnectionString;
    public ActionResult Index()
    {
        try
        {
            //codes
        }
        catch (Exception Ex)
        {
            //The following line is repetitive for every action method.
            var path = HttpContext.Server.MapPath("~/App_Data");
            ExceptionLog.Create(Ex, path);
        }
        return View("AdminDashboard");
    }
}

I would like to avoid such repetition. Is there any way to do it which can work for the entire application as global variable?

Create a BaseController and inherit all your controllers from it — user3559349
– user3559349, Commented Oct 15, 2015 at 11:37
WebConfigurationManager.ConnectionStrings["MyConnectionString"].ConnectionString; as this connection string itself is global in your app lifecycle, why dont you directly use it? — Abdur Rahim
– Abdur Rahim, Commented Oct 15, 2015 at 11:40
Thanks Stephen Mueke. Would you please provide a sample snippet so that I can grab the concept in detail? Specially with the "App_Data" path. — s.k.paul
– s.k.paul, Commented Oct 15, 2015 at 11:40

Brad Christie · Accepted Answer · 2015-10-15 11:55:30Z

4

If it were me, and there were frequent configuration options I needed to access, I would create/expose some kind of IAppConfiguration which I could drop in to my controllers (using dependency injection). Something like:

public interface IAppConfguration
{
    String MyConnectionString { get; }
    String ServerPath { get; }
}
public class AppConfiguration : IAppConfiguration
{
    private readonly HttpContext context;
    public AppConfiguration(HttpContext context)
    {
        this.context = context;
    }

    public String MyConnectionString
    {
        get { return COnfigurationManager.ConnectionStrings["MyConnectionString"].ConnectionString;
    }
    public String ServerPath
    {
        get { return context.Server.MapPath("~/"); }
    }
}

Then you can extend it for different circumstances, sub-sites/areas, etc. Then, bring it in via the controller's constructor:

public class MyController : Controller
{
    private readonly IAppConfiguration config;
    public MyController()
        : this(new AppConfiguration(HttpContext.Current))
    {
    }
    public MyController(IAppConfiguration config)
    {
        this.config = config;
    }

    // reference config.ServerPath or config.MyConnectionString;
}

Taking it a step further, you could add a factory atop this, bring that in as a reference instead, and allow you to get configuration settings for other environments. e.g.

IAppConfiguration config = configFactory.GetConfig(/* environment */);

The thing I like about this approach is allows me to substitute out settings for local [unit/integration] testing. Using base controllers/static classes would make it very difficult to substitute out these values at a later time.

edited Oct 15, 2015 at 11:55

answered Oct 15, 2015 at 11:51

Brad Christie

102k16 gold badges160 silver badges200 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

s.k.paul Over a year ago

Thanks Brad. Can I use this technique in a base controller approach?

Ric Over a year ago

@s.k.paul - combine the approach i've given with this example and you're on your way.

Brad Christie Over a year ago

@s.k.paul" You can, but base controllers become more difficult to emulate in tests (if that's of concern to you). I avoid controller inheritence because it's (typically) a pain to be consistent. However, you could create a static extension (e.g. public static void LoadException(this Controller controller, Exception ex) in LogExceptions class.) But I'd keep things broken out by module and bring them in.

s.k.paul Over a year ago

@Brad, : this(new AppConfiguration(HttpContext.Current)) gives error - object reference is required. Any help?

Brad Christie Over a year ago

If you use DI, you can either use that as your config, or throw that into a static method and pass that method in c'tor. Just used that to show an example of building the class.

Ric · Accepted Answer · 2015-10-15 11:48:45Z

3

Here is an example using a base controller approach:

public abstract class BaseController : Controller
{
    protected string ConnectionString = WebConfigurationManager.ConnectionStrings["MyConnectionString"].ConnectionString;

    protected void LogException(Exception ex)
    {
        var path = HttpContext.Server.MapPath("~/App_Data");
        ExceptionLog.Create(Ex, path);
    }    
}

public class DashboardController : BaseController
{
    public ActionResult Index()
    {
        try
        {
            string conn = base.ConnectionString;
            //codes
        }
        catch (Exception ex)
        {
            base.LogException(ex);
        }
        return View("AdminDashboard");
    }
}

answered Oct 15, 2015 at 11:48

Ric

13.3k3 gold badges32 silver badges36 bronze badges

3 Comments

Kirill Bestemyanov Over a year ago

There you have redundant repeatable try-catch block that do absolutely equal work in every action of every controller.

Ric Over a year ago

It's just one approach - one benefit is that a view can be returned within the try and if an exception is raised, once the catch block has exited, a different view can be returned

s.k.paul Over a year ago

@Ric Thanks. I think this is the simplest way out.

Ric · Accepted Answer · 2015-10-15 11:58:15Z

1

To avoid exception catching you can log it in OnError event handler in global.asax.cs:

protected void Application_Error(object sender, EventArgs e)
{
    HttpContext ctx = HttpContext.Current;

    Exception ex = ctx.Server.GetLastError();

    var path = HttpContext.Server.MapPath("~/App_Data");
    ExceptionLog.Create(Ex, path);
}

you can use connection string name "MyConnectionString" instead of WebConfigurationManager.ConnectionStrings["MyConnectionString"].ConnectionString when pass it to dbcontext or ADO Connection.

But more rightful way is to inject (with Dependency Injection) in controller class that will be responsible for work with database instead of creating it in controller and passing there connection string.

edited Oct 15, 2015 at 11:58

Ric

13.3k3 gold badges32 silver badges36 bronze badges

answered Oct 15, 2015 at 11:47

Kirill Bestemyanov

12k2 gold badges26 silver badges38 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:44:48Z

0

You can inherit controller and then use it for all other controllers, have a look at similar question How can I inherit an ASP.NET MVC controller and change only the view?.

But this will be only accessible in controllers, you can also create a class with static method or property returning back the connection string. This can be used in any path of code where you have access to the class.

edited May 23, 2017 at 11:44

CommunityBot

11 silver badge

answered Oct 15, 2015 at 11:51

Vinay Pandey

8,9539 gold badges38 silver badges57 bronze badges

2 Comments

Vinay Pandey Over a year ago

And the bad design is? Having a central class returning the value? Thats was example by Brad is doing in principle.

Vinay Pandey Over a year ago

I would not create object everytime for given case, though will make it configurable if needed. Anyways OP got his answer happy for him :) . Thanks for your response.

Collectives™ on Stack Overflow

Use global variable in ASP.NET MVC

4 Answers 4

5 Comments

3 Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

3 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related